traverso-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Traverso-commit] traverso/src/traverso/songcanvas CurveView.cpp


From: Ben Levitt
Subject: [Traverso-commit] traverso/src/traverso/songcanvas CurveView.cpp
Date: Fri, 20 Apr 2007 09:12:00 +0000

CVSROOT:        /sources/traverso
Module name:    traverso
Changes by:     Ben Levitt <benjie>     07/04/20 09:12:00

Modified files:
        src/traverso/songcanvas: CurveView.cpp 

Log message:
        revert recent change allowing DragNode to be undoable until I can fix 
related crashes

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/traverso/src/traverso/songcanvas/CurveView.cpp?cvsroot=traverso&r1=1.31&r2=1.32

Patches:
Index: CurveView.cpp
===================================================================
RCS file: /sources/traverso/traverso/src/traverso/songcanvas/CurveView.cpp,v
retrieving revision 1.31
retrieving revision 1.32
diff -u -b -r1.31 -r1.32
--- CurveView.cpp       20 Apr 2007 07:37:42 -0000      1.31
+++ CurveView.cpp       20 Apr 2007 09:12:00 -0000      1.32
@@ -85,14 +85,8 @@
        // So we fake this action to be failed, and thus
        // it won't show up in the history 
 
-       // BEN: What?  This should be undoable.
-       // TODO: Figure out what that comment means...
-       // Remon: @ Ben: Should it? Moving a node fills up the historystack
-       // rather quickly.
-       // The reason I returned -1 here is that the undo code relies on 
-       // a pre-condition that isn't satisfied all the time, and makes 
-       // Traverso segfault on undo when mouse cursor is not above the clip!
-       return 1;
+       // TODO: Fix this so DragNode commands can be undoable
+       return -1;
 }
 
 int DragNode::finish_hold()




reply via email to

[Prev in Thread] Current Thread [Next in Thread]