[Traverso-commit] traverso src/core/Track.cpp src/engine/AudioBus...

[Remon Sijrier]

CVSROOT:        /sources/traverso
Module name:    traverso
Changes by:     Remon Sijrier <r_sijrier>       07/06/04 20:47:17

Modified files:
        src/core       : Track.cpp 
        src/engine     : AudioBus.cpp AudioBus.h 
        src/plugins    : PluginChain.h 
        .              : TODO 

Log message:
        Fixed: [bug #20015] Track Plugins only output during clips

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/traverso/src/core/Track.cpp?cvsroot=traverso&r1=1.60&r2=1.61
http://cvs.savannah.gnu.org/viewcvs/traverso/src/engine/AudioBus.cpp?cvsroot=traverso&r1=1.9&r2=1.10
http://cvs.savannah.gnu.org/viewcvs/traverso/src/engine/AudioBus.h?cvsroot=traverso&r1=1.6&r2=1.7
http://cvs.savannah.gnu.org/viewcvs/traverso/src/plugins/PluginChain.h?cvsroot=traverso&r1=1.9&r2=1.10
http://cvs.savannah.gnu.org/viewcvs/traverso/TODO?cvsroot=traverso&r1=1.7&r2=1.8

Patches:
Index: src/core/Track.cpp
===================================================================
RCS file: /sources/traverso/traverso/src/core/Track.cpp,v
retrieving revision 1.60
retrieving revision 1.61
diff -u -b -r1.60 -r1.61
--- src/core/Track.cpp  30 May 2007 13:57:36 -0000      1.60
+++ src/core/Track.cpp  4 Jun 2007 20:47:16 -0000       1.61
@@ -449,11 +449,11 @@
                                gainFactor *= panFactor;
                        }
                        
-                       
Mixer::mix_buffers_with_gain(bus->get_channel(chan)->get_buffer(nframes), 
mixdown, nframes, gainFactor);
+                       Mixer::mix_buffers_with_gain(bus->get_buffer(chan, 
nframes), mixdown, nframes, gainFactor);
                }
        }
        
-       m_pluginChain->process_post_fader(bus, nframes);
+       processResult |= m_pluginChain->process_post_fader(bus, nframes);
                
        for (int i=0; i<bus->get_channel_count(); ++i) {
                
Mixer::mix_buffers_no_gain(m_song->get_master_out()->get_buffer(i, nframes), 
bus->get_buffer(i, nframes), nframes);

Index: src/engine/AudioBus.cpp
===================================================================
RCS file: /sources/traverso/traverso/src/engine/AudioBus.cpp,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -b -r1.9 -r1.10
--- src/engine/AudioBus.cpp     7 May 2007 21:29:20 -0000       1.9
+++ src/engine/AudioBus.cpp     4 Jun 2007 20:47:16 -0000       1.10
@@ -17,7 +17,7 @@
 along with this program; if not, write to the Free Software
 Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA.
 
-$Id: AudioBus.cpp,v 1.9 2007/05/07 21:29:20 r_sijrier Exp $
+$Id: AudioBus.cpp,v 1.10 2007/06/04 20:47:16 r_sijrier Exp $
 */
 
 #include "AudioBus.h"
@@ -122,16 +122,6 @@
 
 
 /**
- * Get the AudioChannel associated with \a channelNumber 
- * @param channelNumber The channelNumber associated with this AudioBus's 
AudioChannel 
- * @return The AudioChannel on succes, 0 on failure
- */
-AudioChannel * AudioBus::get_channel( int channelNumber )
-{
-       return channels.at(channelNumber);
-}
-
-/**
  * If set to true, all the data going through the AudioChannels in this 
AudioBus
  * will be monitored for their highest peak value.
  * Get the peak value with AudioChannel::get_peak_value()

Index: src/engine/AudioBus.h
===================================================================
RCS file: /sources/traverso/traverso/src/engine/AudioBus.h,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -b -r1.6 -r1.7
--- src/engine/AudioBus.h       7 May 2007 20:48:01 -0000       1.6
+++ src/engine/AudioBus.h       4 Jun 2007 20:47:16 -0000       1.7
@@ -17,7 +17,7 @@
 along with this program; if not, write to the Free Software
 Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA.
 
-$Id: AudioBus.h,v 1.6 2007/05/07 20:48:01 r_sijrier Exp $
+$Id: AudioBus.h,v 1.7 2007/06/04 20:47:16 r_sijrier Exp $
 */
 
 
@@ -106,6 +106,18 @@
        
 };
 
+
+/**
+ * Get the AudioChannel associated with \a channelNumber 
+ * @param channelNumber The channelNumber associated with this AudioBus's 
AudioChannel 
+ * @return The AudioChannel on succes, 0 on failure
+ */
+inline AudioChannel * AudioBus::get_channel( int channelNumber )
+{
+       return channels.at(channelNumber);
+}
+
+
 #endif
 
 //eof

Index: src/plugins/PluginChain.h
===================================================================
RCS file: /sources/traverso/traverso/src/plugins/PluginChain.h,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -b -r1.9 -r1.10
--- src/plugins/PluginChain.h   30 May 2007 13:14:47 -0000      1.9
+++ src/plugins/PluginChain.h   4 Jun 2007 20:47:16 -0000       1.10
@@ -47,7 +47,7 @@
        Command* add_plugin(Plugin* plugin, bool historable=true);
        Command* remove_plugin(Plugin* plugin, bool historable=true);
        void process_pre_fader(AudioBus* bus, unsigned long nframes);
-       void process_post_fader(AudioBus* bus, unsigned long nframes);
+       int process_post_fader(AudioBus* bus, unsigned long nframes);
        void process_fader(audio_sample_t* buffer, nframes_t pos, nframes_t 
nframes) {m_fader->process_gain(buffer, pos, nframes);}
        
        void set_song(Song* song);
@@ -81,13 +81,19 @@
        }
 }
 
-inline void PluginChain::process_post_fader(AudioBus * bus, unsigned long 
nframes)
+inline int PluginChain::process_post_fader(AudioBus * bus, unsigned long 
nframes)
 {
+       if (!m_pluginList.size()) {
+               return 0;
+       }
+       
        for (int i=0; i<m_pluginList.size(); ++i) {
                Plugin* plugin = m_pluginList.at(i);
 //             if (plugin == m_fader) continue;
                plugin->process(bus, nframes);
        }
+       
+       return 1;
 }
 
 #endif

Index: TODO
===================================================================
RCS file: /sources/traverso/traverso/TODO,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -b -r1.7 -r1.8
--- TODO        4 May 2007 01:05:08 -0000       1.7
+++ TODO        4 Jun 2007 20:47:17 -0000       1.8
@@ -1,23 +1,19 @@
 TOBEDONE FOR 0.40.0
 
-* don't push mute/solo to history stack.
+Sheet lenght temporarily reset to wrong value problem again when moving clip 
(undo/redo ..)
 
-* FadeView merging code messes up start of clip when fade lenght is very short 
(1 or even 0 pixels)
-
-* switching to effect mode crashes with 0 tracks
+Broken chipset, needs 3 periods:
+00:1b.0 Audio device: Intel Corporation 82801G (ICH7 Family) High Definition 
Audio Controller (rev 02)
 
 * Curve copy should not use the same id!!!!!!
 
 * when changing the width of fades, the cursor should remain static (as in 
gain)
 
-* Audible glitch when playing over a split point in a splitted audioclip :-( 
:-( :-(
-
 * libsndfile:
        How to record to files larger 4 GB
        Sector misalignment, how to handle.
 
 Less important:
-* horizontal zooming with playhead animated causes 2 paints one at start, one 
at real pos during play!
-
 * Painting last curve nodes has artifacts, 'fixed' by populating polygon with 
as many points as there are
   pixels. This should get a real fix!!
\ No newline at end of file
+