Re: [Tsp-devel] dtest: a distributed test framework

[Frederik Deweerdt]

On Tue, May 22, 2007 at 05:58:25PM +0200, Eric Noulard wrote:
> 2007/5/22, Frederik Deweerdt <address@hidden>:
> >>
> >> Any comment are welcomed.
> >>
> >Well, first, it runs here :). It's really great, specially the
> >expectFromCommand part. A few things, :
> 
> Cool :))
> 
> >- shouldn't the first argument of addRunStep be a real method instead
> >of a string? That would may be simplify the code a bit and I don't see
> >the added value of passing strings around.
> 
> In fact you may "ALREADY" pass an "unbounded method" :))
> The following calls are valid and "equivalent":
Right, I've read to fast the addRunStep method
> 
[...]
> but using this I did not get the overriden method call I wish
> in the  case where the stub is an instance of a SUBCLASS of DTester
> and not a DTester.
Hm, this makes me wonder if they should really be subclasses. Shouldn't
the local and ssh be seen as transports, not testers?  We would use
dtest.DTester("Tester1", dtest.SSHTransport) at init time.

With a tester being
class Tester:
        def __init__(name, transport)
        def ok()
        def barrier()

And a transport
class Trasport:
        def runCommand()
        def waitCommandTermination()

> Besides the correction correspondign to your remark I will
> add a sendFile/getFile on each DTester in order to have
> "building blocks" for sending/getting files to/from the host machine
> executing the DTester.
Good idea, this would be a kind of "set environement" framework? (eg
environment variables, UIDs)
> 
> I have a wealth of ideas coming :))
Happy hacking :)

Fred