[Weechat-dev] [bug #30726] '/reconnect -all': Missing error msg when not connected

[Sven Zallmann]

URL:
  <http://savannah.nongnu.org/bugs/?30726>

                 Summary: '/reconnect -all': Missing error msg when not
connected
                 Project: WeeChat
            Submitted by: szal
            Submitted on: Tue 10 Aug 2010 09:12:44 AM GMT
                Category: commands
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: dev
                IRC nick: szal

    _______________________________________________________

Details:

Excerpt from #weechat log:

2010-04-28 12:00:46 <szal> FlashCode: now that you implemented incrementing
spaces of time between reconnect trials, is Weechat supposed to ignore manual
/reconnect commands?
2010-04-28 12:03:04 <@FlashCode> szal: no, /reconnect should still work
2010-04-28 12:03:13 <szal> FlashCode: well, it doesn'
2010-04-28 12:03:15 <szal> t
2010-04-28 12:03:22 <@FlashCode> szal: what's the problem?
2010-04-28 12:03:24 <szal> (current git tree)
2010-04-28 12:04:46 <szal> FlashCode: I got disconnected (connection hiccup
on my side) earlier this morning, in the meantime reconnect intervals had
increased to 30 mins (after 5 hours), I re-established my connection and typed

2010-04-28 12:05:14 <szal> '/reconnect -all', but nothing happened, not even
any output
2010-04-28 12:05:52 <@FlashCode> szal: ok, I note problem
2010-04-29 11:27:08 <@FlashCode> szal: can't reproduce bug with /reconnect
2010-04-29 11:27:31 <@FlashCode> btw, /reconnect works only if you are
already connected to server
2010-04-29 11:27:44 <@FlashCode> if you want to connect to all opened
servers, try /connect -open
2010-04-29 11:27:55 <@FlashCode> (all opened servers not connected)
2010-04-29 11:28:09 <szal> ah, thx
2010-04-29 11:28:16 <@FlashCode> but /reconnect should display error message
if you are not connected to server
2010-04-29 11:28:37 <szal> in my case it didn't
2010-04-29 11:29:37 <@FlashCode> ah you're right, /reconnect displays error,
but not /reconnect -all
2010-04-29 11:29:41 <@FlashCode> then it's bug
2010-04-29 11:32:00 <szal> what comes to mind here, how about '/reconnect
-$serverAlias'?
2010-04-29 11:39:40 <@FlashCode> szal: you can do /reconnect freenode
2010-04-29 11:40:14 <szal> FlashCode: what I meant, doesn't that throw an
error when the server is disconnected?
2010-04-29 11:40:34 <@FlashCode> yes it should display error
2010-04-29 11:41:02 <@FlashCode> or maybe it should ignore disconnected
server and do only a connect if server is not connected
2010-04-29 11:41:09 <@FlashCode> but that's already job of /connect -open
2010-04-29 11:42:08 <szal> just tried that w/ one of my servers, '/reconnect
server' when server is disconnected does display an error
2010-04-29 11:42:22 <szal> so the bug only goes for '/reconnect -all'
2010-04-29 11:42:42 <@FlashCode> yes, I think so

Short form: '/reconnect <serverName>' displays an error message when Weechat
is not connected to the server, '/reconnect -all' doesn't.

Action to take: Implement error message.

Desireable additional task: It would be nice if, when not connected upon
'/reconnect -all', Weechat would display an explanatory message along the
lines of the following →

'/reconnect -all' does not work when Weechat is not connected to any servers.
If you were disconnected from the network and have server buffers open please
use '/connect -open' instead.

Bug was originally noticed in late April 2010 on, iirc, Weechat 0.3.2-dev;
still present on 0.3.4-dev shortly after release of 0.3.3.




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?30726>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/