[Wesnoth-dev] request for review

[ott]

I've fixed and tested the fix for
    https://savannah.nongnu.org/bugs/index.php?func=detailitem&item_id=13558
but am uncertain about possible negative repercussions of the (trivial)
patch.  In the absence of much IRC discussion, could someone more familiar
with the innards please give the goahead?

A side effect of this is that the suggested savegame name of a replay
called "Scenario replay", once replayed, will be "Scenario replay replay".
This is somewhat appropriate, though it would be trivial to store the
old name and reuse that instead -- opinions please.

We should also make " replay" translatable, it looks very odd in some
languages.

-- address@hidden

Index: src/playcampaign.cpp
===================================================================
RCS file: /cvsroot/wesnoth/wesnoth/src/playcampaign.cpp,v
retrieving revision 1.8
diff -u -r1.8 playcampaign.cpp
--- src/playcampaign.cpp        2 Jul 2005 21:37:19 -0000       1.8
+++ src/playcampaign.cpp        7 Jul 2005 22:32:47 -0000
@@ -127,7 +127,9 @@
                bool save_game_after_scenario = true;
 
                try {
-                       state.label = (*scenario)["name"];
+                       // preserve old label eg. replay
+                       if (state.label.empty())
+                               state.label = (*scenario)["name"];
 
                        LEVEL_RESULT res = 
play_level(units_data,game_config,scenario,video,state,story);
 
@@ -138,7 +140,7 @@
                                const std::string orig_scenario = 
state.scenario;
                                state.scenario = current_scenario;
 
-                               std::string label = state.label + " replay";
+                               std::string label = state.label + _(" replay");
 
                                bool retry = true;