[Wesnoth-patches] [patch #3419] Allow hotkeys bound to oddball keys

[Mark Schreiber]

This mail is an automated notification from the patch tracker
 of the project: Battle for Wesnoth.

/**************************************************************************/
[patch #3419] Latest Modifications:

Changes by: 
                Mark Schreiber <address@hidden>
'Date: 
                Sat 10/09/2004 at 18:36 (GMT)

------------------ Additional Follow-up Comments ----------------------------
v2 patch includes backwards compatibility with old prefs files, eliminating 
compatibility concerns.






/**************************************************************************/
[patch #3419] Full Item Snapshot:

URL: <http://savannah.nongnu.org/patch/?func=detailitem&item_id=3419>
Project: Battle for Wesnoth
Submitted by: Mark Schreiber
On: Fri 10/08/2004 at 08:34

Category:  None
Priority:  1 - Later
Resolution:  None
Privacy:  Public
Assigned to:  None
Originator Email:  
Status:  Open


Summary:  Allow hotkeys bound to oddball keys

Original Submission:  Currently, if one sets up a hotkey bound to the return 
key or the enter key or similar keys, Wesnoth dumps a control character into 
the prefs file, since the character value is stored as a raw value.  The 
Wesnoth config file parser cannot handle this.  This patch makes Wesnoth use 
the SDL name of the key in the preference file (also making the prefs file more 
readable).

Follow-up Comments
------------------


-------------------------------------------------------
Date: Sat 10/09/2004 at 18:36       By: Mark Schreiber <mark7>
v2 patch includes backwards compatibility with old prefs files, eliminating 
compatibility concerns.

-------------------------------------------------------
Date: Fri 10/08/2004 at 15:57       By: Mark Schreiber <mark7>
There is some backwards incompatibility introduced with the old prefs file 
keybinding format with this patch.  For instance, under the default 
keybindings, the space bar is used, which used to be represented with " ", and 
is now represented with "space".  The function keys used to be lowercase ("f1") 
and are now capitalized ("F1").  This affects two default keybindings -- "help" 
and "end unit turn".

The impact of this patch on such keybindings will be to move now-unrecognized 
keybindings to "unknown key".  As Wesnoth is currently pre-1.0, I considered 
this behavior acceptable -- however, backwards compatibility code could be 
added pretty trivially.






File Attachments
-------------------

-------------------------------------------------------
Date: Sat 10/09/2004 at 18:36  Name: wesnoth-hotkey_named_2.diff  Size: 3.33KB  
 By: mark7
Hotkey patch v2
http://savannah.nongnu.org/patch/download.php?item_id=3419&amp;item_file_id=3741

-------------------------------------------------------
Date: Fri 10/08/2004 at 08:34  Name: wesnoth-hotkey_named.diff  Size: 2.9KB   
By: mark7

http://savannah.nongnu.org/patch/download.php?item_id=3419&amp;item_file_id=3734






For detailed info, follow this link:
<http://savannah.nongnu.org/patch/?func=detailitem&item_id=3419>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/