Re: wget2 | Draft: *Integration of ngtcp2 and nghttp3 with wget2 (!527)

[Ander Juaristi (@juaristi)]

Merge request https://gitlab.com/gnuwget/wget2/-/merge_requests/527 was 
reviewed by Ander Juaristi

--
  
Ander Juaristi started a new discussion on libwget/quic.c: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/527#note_1511183100

> +     ret = gnutls_rnd (GNUTLS_RND_RANDOM, dest, destlen);
> +     if (ret < 0) {
> +

???

Why not call here `error_printf`?

Or even better `error_printf_exit`? I guess that letting the program continue 
even if unable to get random data would not be a good idea.

We could even try to fallback to somewhere else, such as reading from 
`/dev/urandom`.

--
  
Ander Juaristi started a new discussion on libwget/quic.c: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/527#note_1511183101

> +                     return WGET_E_TIMEOUT;
> +             }
> +             handshake_read(quic);

Check return value

--
  
Ander Juaristi started a new discussion on libwget/http3.c: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/527#note_1511183102

> +     http3->qpac_encoder_stream = 
> wget_quic_stream_init_unidirectional(http3->quic);
> +     http3->qpac_decoder_stream = 
> wget_quic_stream_init_unidirectional(http3->quic);
> +     http3->client_stream = wget_quic_stream_init_bidirectional(http3->quic);

Check return values.

--
  
Ander Juaristi started a new discussion on libwget/http3.h: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/527#note_1511183103

> +
> +    nghttp3_settings *
> +        settings;

Why not declare these inline, instead of referencing them?

```
nghttp3_conn conn;
nghttp3_mem  mem;
nghttp3_settings settings;
```




-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/527
You're receiving this email because of your account on gitlab.com.