Re: [XForms] Default initialisation of input_return for MULTILINE_INPUT

[Jens Thoms Toerring]

Hi Eberhard,

On Fri, Dec 03, 2010 at 09:59:14AM +0100, Eberhard Kuemmerle wrote:
> according to the documentation, |FL_RETURN_END_CHANGED
> <http://xforms-toolkit.org/doc/xforms_6.html#FL_005fRETURN_005fEND_005fCHANGED>
> should be set as the default value for all input objects.
> But that is not true for ||FL_MULTILINE_INPUT, the default
> initialisation is missing there.
> To correct that, I suggest the following patch to the function fl_add_input:
> 
> --- input.c_orig   # input.c from xforms-1.0.93sp1.tar.gz
> +++ input.c
> @@ -1711,6 +1711,7 @@
>          fl_add_child( sp->dummy, sp->hscroll );
> 
>          fl_set_object_callback( sp->input, input_cb, 0 );
> +        fl_set_object_return( sp->dummy, FL_RETURN_END_CHANGED );
>      }
> 
>      fl_add_object( fl_current_form, sp->dummy );

Thank you very much for bringing that to my attention, there's
definitely something broken! And thanks for the patch. I will
take a closer look over the weekend.

                      Best regards, Jens
-- 
  \   Jens Thoms Toerring  ________      address@hidden
   \_______________________________      http://toerring.de