[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[AUCTeX-devel] Re: [AUCTeX-diffs] Changes to auctex/ChangeLog
From: |
Masayuki Ataka |
Subject: |
[AUCTeX-devel] Re: [AUCTeX-diffs] Changes to auctex/ChangeLog |
Date: |
Wed, 25 Jan 2006 05:50:48 +0900 (JST) |
From: David Kastrup <address@hidden>
Subject: Re: [AUCTeX-diffs] Changes to auctex/ChangeLog
Date: Mon, 23 Jan 2006 22:16:25 +0100
> Masayuki Ataka <address@hidden> writes:
>
> > From: David Kastrup <address@hidden>
> > Subject: Re: [AUCTeX-diffs] Changes to auctex/ChangeLog
> > Date: Sun, 22 Jan 2006 21:08:28 +0100
> >
> >> Masayuki Ataka <address@hidden> writes:
> >>
> >> > Index: auctex/ChangeLog
> >> > diff -u auctex/ChangeLog:5.1280 auctex/ChangeLog:5.1281
> >> > --- auctex/ChangeLog:5.1280 Sun Jan 22 13:25:44 2006
> >> > +++ auctex/ChangeLog Sun Jan 22 15:02:52 2006
> >> > @@ -1,3 +1,19 @@
> >> > +2006-01-22 Ikumi Keita <address@hidden>
> >> > +
> >> > + * tex.el (TeX-command-list): Removed TeX-run-dviout because
> >> > dviout
> >> > + here is only work with Emacs on MS-DOS.
> >>
> >> Uh, I can't remember a discussion about that change,
> >
> > First of all, I apologize that I removed codes of run-dviout
> > without discussions.
> >
> >> Is there a good reason for removing the run-dviout functionality,
> >> given that such platforms are definitely in use?
> >
> > I put the patch for run-dviout at the end of this mail for your
> > help.
> >
> > The function TeX-run-dviout is for MS-DOS and PC-9801.
>
> Uh, no. It _special-cases_ those two operating systems, but I don't
> see anything that would prevent this function from running, for
> example, with dviout for Windows. _Exactly_ because the cases for
> MS-DOS and PC-9801 are specially checked and treated.
>
Okay. I didn't think about backward compatibility.
I've reverted my change.
One comment from Ikumi-San.
dviout for Windows works with TeX-run-discard.
And he suggests renaming TeX-run-dviout to TeX-run-discard-foreground,
TeX-run-dviout should be alias to TeX-run-discard-foreground.
I put the patch from Ikumi-San at the end of email.
I feel good at Ikumi-San's change.
> > Anybody uses Emacs21 on MS-DOS system?
>
> Eli Zaretskii is one of the most active Emacs developers and
> frequently reports issues with Emacs 22 development on MSDOS on the
> Emacs developer list.
>
That's good news to me because such an old system still lives ;)
> > If so, I will revert my change.
>
> Since AUCTeX also contains a lot of other MSDOS support (like
> synchronous sentinels), it does not make sense removing parts of it
> without good reason. If they are _known_ to be broken and nobody can
> maintain them, that would be reasonable.
>
> But even then, such a change should be proposed on the list and not
> just done behind people's back.
>
I understand.
Forgive me that I havn't proposed on the list.
> Is there a particular technical reason that makes removing this
> desirable? If so, we can discuss it.
>
P.S.
---
Sorry for my delay of replay. My SMTP setting was in trouble.
--- tex-buf.el-11.82 Fri Nov 18 02:03:23 2005
+++ tex-buf.el Wed Jan 25 00:30:54 2006
@@ -680,15 +680,16 @@
TeX-shell-command-option
command)))
-(defun TeX-run-dviout (name command file)
- "Call process with second argument, discarding its output. With support
-for the dviout previewer, especially when used with PC-9801 series."
+(defun TeX-run-discard-foreground (name command file)
+ "Call process with second argument in the foreground, discarding its output.
+With support for MS-DOS, especially when dviout is used with PC-9801 series."
(if (and (boundp 'dos-machine-type) (eq dos-machine-type 'pc98)) ;if
PC-9801
(send-string-to-terminal "\e[2J")) ; clear screen
(call-process TeX-shell (if (eq system-type 'ms-dos) "con") nil nil
TeX-shell-command-option command)
(if (eq system-type 'ms-dos)
(redraw-display)))
+(defalias 'TeX-run-dviout 'TeX-run-discard-foreground)
(defun TeX-run-background (name command file)
"Start process with second argument, show output when and if it arrives."
--- tex.el-11.82 Fri Dec 9 04:37:16 2005
+++ tex.el Wed Jan 25 00:44:37 2006
@@ -235,8 +235,8 @@
TeX-run-silent: Start the process in the background.
-TeX-run-dviout: Special hook for the Japanese dviout previewer for
-PC-9801.
+TeX-run-discard-foreground: Start the process in the foreground,
+discarding its output.
To create your own hook, define a function taking three arguments: The
name of the command, the command string, and the name of the file to
@@ -269,6 +269,7 @@
(function-item TeX-run-discard)
(function-item TeX-run-background)
(function-item TeX-run-silent)
+ (function-item TeX-run-discard-foreground)
(function-item TeX-run-dviout)
(function-item TeX-run-ispell-on-document)
(function :tag "Other"))