Re: [AUCTeX-devel] Small patch for MinionPro.el

[Mosè Giordano]

Hi Arash,

2014-10-11 8:10 GMT+02:00 Arash Esbati <address@hidden>:
> Hi,
>
> may I propose a small patch for MinionPro.el?  Rationale: \figureversion can 
> contain `style' and `alignment' (e.g., \figureversion{osf,prop})
>
> --- MinionPro.el~       2014-10-06 18:57:32.000000000 +0200
> +++ MinionPro.el        2014-10-11 07:49:26.404204800 +0200
> @@ -36,11 +36,10 @@
>     (TeX-add-symbols
>      ;; New symbols
>      '("figureversion"
> -      (TeX-arg-eval completing-read "Figure style: "
> -                   '(("text") ("osf")
> -                     ("lining") ("lf")
> -                     ("tabular") ("tab")
> -                     ("proportional") ("prop"))))
> +      (TeX-arg-key-val (("text") ("osf")
> +                        ("lining") ("lf")
> +                        ("tabular") ("tab")
> +                        ("proportional") ("prop")) "Style, align."))
>      '("smallfrac" "Numerator" "Denominator")
>      '("slantfrac" "Numerator" "Denominator")
>      ;; IMHO they should be added to the other \text.. and \..shape commands

May I ask you where this feature is described?  The package
documentation is not so clear to me about this and I don't have to
package to test with it.  IMHO, in this case
`TeX-completing-read-multiple' is more appropriate than
`TeX-arg-key-val' as there is no key-val here, ie
--8<---------------cut here---------------start------------->8---
(TeX-arg-eval mapconcat 'identity (TeX-completing-read-multiple
                   "Figure style: "
                   '(("text") ("osf")
                     ("lining") ("lf")
                     ("tabular") ("tab")
                     ("proportional") ("prop"))) ",")
--8<---------------cut here---------------end--------------->8---

Bye,
Mosè