[AUCTeX-devel] Reversed logic of TeX-record-buffer

[Ikumi Keita]

Hi all,

I think that `TeX-pop-to-buffer' uses `TeX-record-buffer' in the
reversed sense.

The customize option `TeX-record-buffer' is defined as:
----------------------------------------------------------------------
(defcustom TeX-record-buffer nil
  "Whether to record buffer names of generated TeX buffers.
When non-nil, these buffers are put at the front of the list of
recently selected ones."
  :group 'TeX-command
  :type 'boolean)
----------------------------------------------------------------------
However, it is used in `TeX-pop-to-buffer' as:
----------------------------------------------------------------------
(defun TeX-pop-to-buffer (buffer &optional other-window norecord)
  "Compatibility wrapper for `pop-to-buffer'.
... (snip) ...
Optional third arg NORECORD non-nil means do not put this buffer
at the front of the list of recently selected ones."
  (pop-to-buffer buffer other-window (and norecord TeX-record-buffer)))
----------------------------------------------------------------------
Therefore, the default value nil of `TeX-record-buffer' actually forces
to _record_ the specified buffer at the front of the list of recently
selected ones unconditionally, contrally to its name and doc string.
Due to this discrepancy, *TeX errors* buffer is offered as default for
C-x C-b in the tex file buffer once after C-c ` is issued.

I think `TeX-pop-to-buffer' should be implemented as
  (pop-to-buffer buffer other-window (and norecord (not TeX-record-buffer)))
according to its name and doc string.

Is it enough to just change as proposed above?  Or should we provide some
compatibility treatment for users who have customized this option?

Regards,
Ikumi Keita