Re: AUCTeX tool bar on emacs built with gtk3

[Tassilo Horn]

Ikumi Keita <ikumi@ikumi.que.jp> writes:

Hi Ikumi,

>> I think it is not our business to set `tool-bar-style' explicitly but
>> rather the user should do that based on his or her preferences.
>
>> Here, the value is nil which, according to its docstring, should mean
>> "use the system default or image if no system default".  So I guess
>> there's also some GTK setting which a user could configure, and then
>> Emacs/AUCTeX should follow suite.
>
> I examined other emacs built-in libraries to figure out how they
> suppress redundant text labels. It seems that there is an undocumented
> feature such that non-nil :vert-only property for tool bar specification
> does the job. (And I noticed a related topic in emacs-devel archive:
> https://lists.gnu.org/archive/html/emacs-devel/2020-09/msg00935.html )
>
> The revised patch is attached below. Now AUCTeX tool bar follows the
> user preference even when `tool-bar-style' is customized to `both',
> presenting labels under icons. (In that case, "Preview" icon lacks the
> label, at least for me. It seems that either emacs or gtk omits the
> label text "Preview at point" since it's too long to fit there.)
>
> What do you think about it?

Looks good to me. :-)

Thanks,
Tassilo