main-branch: Values of `TeX-lisp-directory' and `TeX-data-directory'

[Arash Esbati]

Hi Tassilo,

I installed AUCTeX from ELPA and see the following:

,----[ C-h v TeX-lisp-directory RET ]
| TeX-lisp-directory is a variable defined in ‘tex-site.el’.
| 
| Its value is "/path/to/.emacs.d/elpa/auctex-14.0.5/" 
`----

and we have this in tex-site.el

  (add-to-list 'load-path TeX-lisp-directory)

So `load-path' has 2 entries:

  "/path/to/.emacs.d/elpa/auctex-14.0.5/"
  "/path/to/.emacs.d/elpa/auctex-14.0.5"

Note the final slash.  `load-path' docstring says that both version are
tolerated, but I think we can fix our addition with this change:

--8<---------------cut here---------------start------------->8---
diff --git a/GNUmakefile b/GNUmakefile
index 73bdeace..617daea1 100644
--- a/GNUmakefile
+++ b/GNUmakefile
@@ -106,8 +106,8 @@ LASTVERSION:=$(shell grep "^;; Version:" auctex.el \
 AUCTEXVERSION:=$(if $(THISVERSION),$(THISVERSION),$(LASTVERSION).$(AUCTEXDATE))

 tex-site.el: tex-site.el.in
-       sed -e 's|@lisppackagelispdir@|(file-name-directory load-file-name)|'\
-           -e 's|@lisppackagedatadir@|(file-name-directory load-file-name)|'\
+       sed -e 's|@lisppackagelispdir@|(directory-file-name 
(file-name-directory load-file-name))|'\
+           -e 's|@lisppackagedatadir@|(directory-file-name 
(file-name-directory load-file-name))|'\
            -e 's|@lispautodir@|(if (file-writable-p "/usr/local/var/auctex") 
"/usr/local/var/auctex" "~/.emacs.d/auctex")|'\
            -e 's|@AUCTEXVERSION@|$(AUCTEXVERSION)|'\
            -e 's|@AUCTEXDATE@|$(AUCTEXDATE)|'\
--8<---------------cut here---------------end--------------->8---

WDYT?  This was also discussed in bug#31150.

And I see the files .dir-locals.el and .elpaignore are also installed.
Are they really necessary, or can they be excluded?

Best, Arash