Re: Stop preprocessing `tex-site.el`

[Stefan Monnier]

Arash Esbati <arash@gnu.org> wrote:
> Thanks, I did 'make clean' and applied your patch locally.  Running make
> again gives:
>
> --8<---------------cut here---------------start------------->8---
> In toplevel form:
> bib-cite.el:591:11: Error: Recursive ‘require’ for feature ‘tex’
>
> In toplevel form:
> context.el:54:11: Error: Recursive ‘require’ for feature ‘tex’
>
> In toplevel form:
> context-nl.el:33:11: Error: Recursive ‘require’ for feature ‘tex’
> make: *** [GNUmakefile:80: context-nl.elc] Error 1
>
> In toplevel form:
> context-en.el:33:11: Error: Recursive ‘require’ for feature ‘tex’
> make: *** [GNUmakefile:80: context-en.elc] Error 1
>
> In toplevel form:
> font-latex.el:38:11: Error: Recursive ‘require’ for feature ‘tex’
> make: *** [GNUmakefile:80: font-latex.elc] Error 1
> --8<---------------cut here---------------end--------------->8---

Ha, that's a funny one, thanks:

The problem comes from `package-get-version` being autoloaded from
`package` which requires a few other packages, in this case `browse-url`
which itself requires `url` which ends up loading `auctex/styles/url.el`
(which itself requires `tex`, hence the loop) because we add the
`styles` subdir to the `load-path` for a reason that escapes me.

The additional patch below seems to fix it.
The `styles` subdir was added to the compilation's `load-path` by:

    commit a9c37b7ecd2353093fbecc84561fcace1ac8be80
    Author: Tassilo Horn <tsdh@gnu.org>
    Date:   Sun Oct 25 16:07:28 2020 +0100
    
        ; Add new make target dynvars-check

Tassilo, do you remember why you did that?


        Stefan "who doesn't use AUCTeX's makefile to compile AUCTeX"


diff --git a/lpath.el b/lpath.el
index 63071029a2..56709dc510 100644
--- a/lpath.el
+++ b/lpath.el
@@ -1,6 +1,6 @@
 ;;; This file is only used for installing AUCTeX.  -*- lexical-binding: t; -*-
 
-;; Copyright (C) 2013-2021  Free Software Foundation, Inc.
+;; Copyright (C) 2013-2024  Free Software Foundation, Inc.
 ;; Maintainer: auctex-devel@gnu.org
 
 ;;; It is not a part of AUCTeX itself.
@@ -9,7 +9,7 @@
 
 (let ((auctex-dir (file-name-directory load-file-name)))
   (add-to-list 'load-path auctex-dir)
-  (add-to-list 'load-path (expand-file-name "style" auctex-dir))
+  ;; (add-to-list 'load-path (expand-file-name "style" auctex-dir))
   (setq TeX-lisp-directory "<none>"
         TeX-auto-global "<none>"))