Re: [AUCTeX] Patch to tex-info.el to support node name completion in @..ref commands, and solve a few other pbs

[Mosè Giordano]

Il 28/ott/2015 10:33, "Tassilo Horn" <address@hidden> ha scritto:
>
> Vincent Belaïche <address@hidden> writes:
>
> > I have not tested the change, but reading this:
> >
> >       (message "There are duplicate nodes:")
> >       (dolist (dup (nreverse dups))
> >     (message "    %s on line %d" (car dup) (cdr dup))))
> >
> > I gather that the "There are duplicate nodes:" message will be output
> > even when dups is nil. Furthermore if you have N duplicates you will have
> > N+1 message and only the last one will remain in the minibuffer ---
> > meaning that the user has to go to the *Message* buffer. That is why I
> > was using the `warn' function. If you want to use `message' it might be
> > better to contatenate all the messages together, maybe something like
> > this (not tested):
> >
> > (and dups
> >    (message "There are duplicate nodes: %s"
> >       (mapconcat (lambda (x) (format "%s on line %d"
> >                    (car x) (cdr x))) (nreverse dups) "\n\t")))
>
> Gosh, and there was also a void-variable error because I didn't test
> again after removing the nodes argument. ;-)
>
> Ok, now I've fixed it and use `display-warning' with CLASS set to
> 'AUCTeX so that users also see who issued the warning.  That's much
> better.  But I'm not entirely sure if very old emacsen have that: I
> checked GNU Emacs 22+ and XEmacs 21.5 but it would be great if somebody
> could check Emacs 21.4 and XEmacs 21.4.

Didn't test the whole patch, but I can confirm XEmacs 21.4 has display-warning.

Bye,
Mosè