[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Automake-commit] [SCM] GNU Automake branch, maint, updated. v1.11-247-g
|
From: |
Stefano Lattarini |
|
Subject: |
[Automake-commit] [SCM] GNU Automake branch, maint, updated. v1.11-247-gfdb2764 |
|
Date: |
Wed, 01 Dec 2010 22:55:24 +0000 |
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Automake".
http://git.sv.gnu.org/gitweb/?p=automake.git;a=commitdiff;h=fdb2764f70ff5f3aed51a61baf3b72511ffb9d11
The branch, maint has been updated
via fdb2764f70ff5f3aed51a61baf3b72511ffb9d11 (commit)
via 22ee3bdfb7d140f61e276eae28fbabe321f6c32a (commit)
via 2601fd8f5688a2e9cb4c723c1c42007d3c019fca (commit)
from fadd73d775e558ab476bebd59a39a42e97fbdf39 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 79 +++++++++++++-------
tests/Makefile.am | 9 ++-
tests/Makefile.in | 9 ++-
tests/{silentlex.test => silent-lex-gcc.test} | 13 ++--
tests/{silentlex.test => silent-lex-generic.test} | 9 +-
tests/{silent5.test => silent-many-gcc.test} | 15 ++--
tests/{silent5.test => silent-many-generic.test} | 13 ++-
tests/{silentyacc.test => silent-yacc-gcc.test} | 13 ++--
.../{silentyacc.test => silent-yacc-generic.test} | 9 +-
9 files changed, 103 insertions(+), 66 deletions(-)
copy tests/{silentlex.test => silent-lex-gcc.test} (90%)
rename tests/{silentlex.test => silent-lex-generic.test} (92%)
copy tests/{silent5.test => silent-many-gcc.test} (91%)
rename tests/{silent5.test => silent-many-generic.test} (91%)
copy tests/{silentyacc.test => silent-yacc-gcc.test} (90%)
rename tests/{silentyacc.test => silent-yacc-generic.test} (92%)
diff --git a/ChangeLog b/ChangeLog
index ffbeb69..e8864f1 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,26 @@
+2010-11-25 Stefano Lattarini <address@hidden>
+
+ Fix spurious failures in `silent*.test' for $CC != gcc
+ In some tests on automake-produced silent rules, we forced the
+ use of gcc depmode to improve testsuite coverage; but this has
+ unsurprisingly led to spurious failures when some non-GNU C
+ compilers were used. So we are now careful to require GCC in
+ tests that force gcc depmode.
+ From reports by Ralf Wildenhues.
+ * silent5.test: Test removed, its content split into ...
+ * silent-many-generic.test, silent-many-gcc.test: ... these new
+ sister tests, the latter of which forces gcc depmode and lists
+ "gcc" in $required.
+ * silentlex.test: Test removed, its content split into ...
+ * silent-lex-generic.test, silent-lex-gcc.test: ... these new
+ sister tests, the latter of which forces gcc depmode and lists
+ "gcc" in $required.
+ * silentyacc.test: Test removed, its content split into ...
+ * silent-yacc-generic.test, silent-yacc-gcc.test: ... these new
+ sister tests, the latter of which forces gcc depmode and lists
+ "gcc" in $required.
+ * tests/Makefile.am (TESTS): Updated.
+
2010-11-21 Stefano Lattarini <address@hidden>
Tests: consistently use "|| Exit 1" after ". ./defs".
@@ -111,7 +134,7 @@
Fix regression in ansi.test (failure on AIX 5.3).
* tests/ansi.test: Remove redundant hackish check done using a
- hand-postprocessed Makefile.in. This checs worked by setting
+ hand-postprocessed Makefile.in. This check worked by setting
the `$(SHELL)' macro on the command line of make, but this is
not supported by the AIX 5.3 make implementation.
This bug has been lurking for a long time, and was activated by
@@ -152,11 +175,11 @@
2010-11-07 Stefano Lattarini <address@hidden>
- Fix a bug in variable concatanation with `+='.
+ Fix a bug in variable concatenation with `+='.
* lib/Automake/VarDef.pm (append): Since the content of the
"appended-to" variable is going to be unconditionally normalized
later, simply separate the appended value with a single whitespace
- character, instead of trying to be uselesssly smarter by using
+ character, instead of trying to be uselessly smarter by using
escaped newlines. This fixes a bug in which extra backslashes
where erroneously inserted in the variable's final value.
* tests/pluseq11.test: New test, exposing the bug.
@@ -214,7 +237,7 @@
* tests/help3.test: Likewise, and fix a botched comment.
* tests/help.test: Likewise. Also, use "AUTOMAKE_fails ..."
instead of "$AUTOMAKE ... && Exit 1", for consistency and to
- please maintainet-check.
+ please maintainer-check.
* tests/help2.test: Likewise.
2010-10-03 Stefano Lattarini <address@hidden>
@@ -372,7 +395,7 @@
* tests/help-silent.test: Likewise.
* tests/help-upc.test: Likewise.
* tests/mmode.test: Remove tests on `configure --help' output,
- they are supersed by tests in `help-maintainer.test'.
+ they are superseded by tests in `help-maintainer.test'.
* tests/Makefile.am (TESTS): Update.
2010-09-14 Stefano Lattarini <address@hidden>
@@ -388,7 +411,7 @@
Fix regression in test `colon4.test'.
* tests/colon4.test: Fix botched editing to `configure.in'
that made the test useless. Since we are at it, improve
- comments and make grepping of generated Makefile.in slighty
+ comments and make grepping of generated Makefile.in slightly
stricter.
Regression introduced by change "Modernize, improve and/or
extend tests `colon*.test" (Stefano Lattarini, 2010-08-08).
@@ -408,7 +431,7 @@
* tests/confh.test: Run "autoconf", "configure" and "make check",
instead of munging/grepping the generated `Makefile.in'.
* tests/confh4.test: Relax the grepping of Makefile.in w.r.t.
- white spaces. Do not create usless dummy source file `foo.c'
+ white spaces. Do not create useless dummy source file `foo.c'
and useless dummy header file `acconfig.h'.
(configure.in): Remove superfluous call to `AC_OUTPUT'.
* tests/confh6.test: Add trailing `:' command.
@@ -492,7 +515,7 @@
`$me' over hard-coded test name.
* tests/aclocal6.test: Likewise.
* tests/aclocal18.test: Add trailing `:' command, and make
- some grepping slighty stricter.
+ some grepping slightly stricter.
* tests/acloca14.test: Likewise. Also, prefer `diff' over
`cmp', and add some "cosmetic" blank lines.
@@ -535,20 +558,20 @@
README, NEWS), since we run automake in foreign mode anyway.
* tests/pr72.test: Enable `errexit' shell flags, and related
changes. Extend existing checks a bit.
- * tests/pr9.test: Likewise. Also, avoid obolescent constructs in
+ * tests/pr9.test: Likewise. Also, avoid obsolescent constructs in
the generated `configure.in', and extend existing checks over the
generated tarball a bit.
* tests/pr87.test: Enable `errexit' shell flags, and related
changes. Add a trailing `:' command. Also, do not create dummy
files required by "gnu" mode (e.g. README, NEWS), since we run
automake in foreign mode anyway.
- * tests/pr243.test: Avoid obolescent constructs in the generated
+ * tests/pr243.test: Avoid obsolescent constructs in the generated
`configure.in'. Enable the `errexit' shell flag, and related
changes. Cosmetic changes to spacing, add trailing `:' command,
and add a "FIXME" comment.
* tests/pr266.test: Likewise, and add explicit command line switch
`--enable-dependecy-tracking' to the ./configure call.
- * tests/pr279.test: Avoid obolescent constructs in the generated
+ * tests/pr279.test: Avoid obsolescent constructs in the generated
`configure.in'; also, use the `configure.in' stub created by
./defs, rather than writing it from scratch. Enable `errexit'
shell flag, and related changes. Add trailing `:' command.
@@ -633,7 +656,7 @@
* tests/confvar.test: Likewise, and make grepping of Makefile.in
stricter.
* tests/confvar2.test: Likewise.
- * tests/conflnk3.test: Cosmetic changes, and re-enable a temporarly
+ * tests/conflnk3.test: Cosmetic changes. Re-enable a temporarily
disabled test (which didn't work with autoconf <= 2.59, but now we
are requiring autoconf 2.62, so...)
* tests/conflnk4.test: Cosmetic changes, and extend existing tests
@@ -671,7 +694,7 @@
* tests/depcomp.test: Do not create useless dummy source files.
Add a trailing `:' command.
* tests/depcomp2.test: Use `unset' on the CFLAG variable to ensure
- it's not in in the environment, rather tthan exporting it with an
+ it's not in in the environment, rather than exporting it with an
empty value. Do not pass CC=gcc to configure, as that's already
done in ./defs since we have gcc in $required. Ensure verbose
printing of captured stderr, and normalize its checking. Add a
@@ -689,7 +712,7 @@
and dollar characters in grep regexps. Explicitly declare phony
targets as such in the created Makefile.am. Add a trailing `:'
command.
- * tests/depcomp6.test: Consistenty use m4 quoting in the generated
+ * tests/depcomp6.test: Consistently use m4 quoting in the generated
configure.in. Cosmetic fixes to spacing. Make the "dummy" `if'
statement required by OpenBSD's sh `set -e' more robust, and add
explanatory comments to it.
@@ -729,7 +752,7 @@
* tests/subobj9.test: Move setting of `errexit' shell flag earlier
in the script (just after inclusion of ./defs). Fail the test if
`make distcheck' fails. Ensure verbose printing of captured make
- stdout. Avoid uselsss fork by doing simple grep instead of using
+ stdout. Avoid useless fork by doing simple grep instead of using
test -n "`COMMAND | grep ...`".
(configure.in): Normalize the call to AC_INIT w.r.t. other tests.
(Makefile.am): Explicitly mark target "print" as phony.
@@ -1003,7 +1026,7 @@
source file.
* tests/suffix7.test: Likewise.
* tests/suffix5.test: Enable `errexit' shell flag, and related
- changes. Make grepping of Makefile.in slighty stricter.
+ changes. Make grepping of Makefile.in slightly stricter.
* tests/suffix.test: Enable `errexit' shell flag, and related
changes. Also, do not redirect grep output to /dev/null, as this
might unmotivatedly hide useful information.
@@ -1018,7 +1041,7 @@
$FGREP rather than plain grep.
* tests/suffix11.test: Likewise.
* tests/suffix12.test: Likewise.
- * tests/suffix9.test: Prefet cat + here-doc over echo to append to
+ * tests/suffix9.test: Prefer cat + here-doc over echo to append to
the `configure.in' stub. Cosmetic changes.
* tests/suffix13.test: Cosmetic spacing change.
@@ -1029,7 +1052,7 @@
useless `if' statement is indeed required.
Add useful comment in test script obsolete.test.
- * tests/obsolte.test: Add a comment explaining why we need
+ * tests/obsolete.test: Add a comment explaining why we need
an indirection in adding $AUTOUPDATE to $required.
Normalize whitespaces in 'tests/Makefile.am'.
@@ -1055,7 +1078,7 @@
changes, and a couple of unrelated cosmetic changes.
* tests/recurs.test: Use the `configure.in' stub created by
`./defs', rather than writing one from scratch. Make grepping
- of Automake stderr slighty stricter.
+ of Automake stderr slightly stricter.
* tests/substtarg.test: Likewise.
* tests/strip.test: Likewise, and move the call to `set -e'
earlier (just after the inclusion of `./defs'). Also, make sure
@@ -1068,7 +1091,7 @@
in ./defs). Avoid potential problems with unpredictable make
output. Finally, make grepping of Makefile.in stricter.
* tests/substre2.test: Ensure verbose printing of the captured
- make's output, and make its grepping slighty stricter.
+ make's output, and make its grepping slightly stricter.
* tests/cygwin32.test: Enable `errexit' shell flag, and related
changes. Also, do not create useless dummy source/data files.
* tests/scripts.test: Likewise.
@@ -1081,7 +1104,7 @@
here-doc, not using echo.
* tests/pluseq10.test: Make sure that the captured output of
`make' command is always displayed. Where possible, use $FGREP
- instead of grep (this change makes some checks slighty stricter).
+ instead of grep (this change makes some checks slightly stricter).
* tests/pluseq8.test: Enable `errexit' shell flag, with related
changes.
* tests/pluseq.test: Likewise. Also, do not create useless dummy
@@ -1092,7 +1115,7 @@
* tests/pluseq4.test: Likewise.
* tests/pluseq6.test: Likewise.
* tests/pluseq7.test: Do not create useless dummy source file.
- * tests/pluseq9.test: Slighty extended w.r.t. the grepping of
+ * tests/pluseq9.test: Slightly extended w.r.t. the grepping of
Automake stderr. Some unrelated cosmetic changes.
Testsuite: ensure verbose printing of captured stderr.
@@ -1152,7 +1175,7 @@
2010-06-11 Stefano Lattarini <address@hidden>
Improve determination of PATH separator in bootstrap script.
- * bootstrap: Detemine what the PATH separator is the same way
+ * bootstrap: Determine what the PATH separator is the same way
autoconf does.
Minor improvements in bootstrap script.
@@ -1179,7 +1202,7 @@
$AUTOMAKE, and improve the positioning of an $ACLOCAL call.
* tests/exeext4.test: Use $FGREP instead of grep, where possible.
Make auxiliary rules in the generated Makefile more silent.
- These changes make some checks slighty stricter.
+ These changes make some checks slightly stricter.
* tests/ext2.test: Call `Exit 1' if inclusion of `./defs' fails.
* tests/gettext2.test: Place final `:' at the end of the script,
rather than in the middle.
@@ -1205,7 +1228,7 @@
* tests/python2.test: Improved verbose messages.
Make test `ammissing.test' stricter.
- * tests/ammissing.test: Fail if $ACLOCAL succeds unexpectedly.
+ * tests/ammissing.test: Fail if $ACLOCAL succeeds unexpectedly.
Enable `errexit' shell flag.
2010-06-08 Stefano Lattarini <address@hidden>
@@ -1287,9 +1310,9 @@
* tests/nodep.test: Likewise.
* tests/nodepcomp.test: Likewise.
* tests/f90only.test: Likewise, and remove botched/obsoleted
- comments and unecessary commands.
+ comments and unnecessary commands.
* tests/fonly.test: Likewise, and remove botched/obsoleted
- comments and unecessary commands.
+ comments and unnecessary commands.
* tests/discover.test: Likewise, and made stricter.
Enable `errexit' shell flag in all tests cxx*.test.
@@ -1422,7 +1445,7 @@
Extend test on `nostdinc' automake option.
* tests/nostdinc.test: Enable `errexit' shell flag. Related and
unrelated minor changes. Make the grepping of the generated
- Makefile.in slighty stricter. Generate and run configure, so that
+ Makefile.in slightly stricter. Generate and run configure, so that
the generated Makefile can be grepped too.
2010-05-23 Ralf Wildenhues <address@hidden>
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 5f1ab9e..dab04e3 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -632,15 +632,18 @@ silent.test \
silent2.test \
silent3.test \
silent4.test \
-silent5.test \
silent6.test \
silent7.test \
silent9.test \
silentcxx.test \
silentf77.test \
silentf90.test \
-silentlex.test \
-silentyacc.test \
+silent-many-gcc.test \
+silent-many-generic.test \
+silent-lex-gcc.test \
+silent-lex-generic.test \
+silent-yacc-gcc.test \
+silent-yacc-generic.test \
sinclude.test \
srcsub.test \
srcsub2.test \
diff --git a/tests/Makefile.in b/tests/Makefile.in
index 140b178..de21f43 100644
--- a/tests/Makefile.in
+++ b/tests/Makefile.in
@@ -899,15 +899,18 @@ silent.test \
silent2.test \
silent3.test \
silent4.test \
-silent5.test \
silent6.test \
silent7.test \
silent9.test \
silentcxx.test \
silentf77.test \
silentf90.test \
-silentlex.test \
-silentyacc.test \
+silent-many-gcc.test \
+silent-many-generic.test \
+silent-lex-gcc.test \
+silent-lex-generic.test \
+silent-yacc-gcc.test \
+silent-yacc-generic.test \
sinclude.test \
srcsub.test \
srcsub2.test \
diff --git a/tests/silentlex.test b/tests/silent-lex-gcc.test
similarity index 90%
copy from tests/silentlex.test
copy to tests/silent-lex-gcc.test
index 5ad430e..426dc50 100755
--- a/tests/silentlex.test
+++ b/tests/silent-lex-gcc.test
@@ -14,9 +14,10 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-# Check silent-rules mode for Lex.
+# Check silent-rules mode for Lex, forcing gcc depmode.
+# Keep this in sync with sister test `silent-lex-generic.test'.
-required='flex'
+required='flex gcc'
. ./defs || Exit 1
set -e
@@ -63,11 +64,11 @@ $ACLOCAL
$AUTOMAKE --add-missing
$AUTOCONF
-# configure once for fastdep, once for non-fastdep, once for nodep
+# Force gcc ("fast") depmode.
+# This apparently useless "for" loop is here to simplify the syncing
+# with sister test `silent-lex-gcc.test'.
for config_args in \
- '' \
- am_cv_CC_dependencies_compiler_type=gcc \
- --disable-dependency-tracking
+ am_cv_CC_dependencies_compiler_type=gcc
do
./configure $config_args --enable-silent-rules
diff --git a/tests/silentlex.test b/tests/silent-lex-generic.test
similarity index 92%
rename from tests/silentlex.test
rename to tests/silent-lex-generic.test
index 5ad430e..66535e8 100755
--- a/tests/silentlex.test
+++ b/tests/silent-lex-generic.test
@@ -15,6 +15,7 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# Check silent-rules mode for Lex.
+# Keep this in sync with sister test `silent-lex-gcc.test'.
required='flex'
. ./defs || Exit 1
@@ -63,11 +64,11 @@ $ACLOCAL
$AUTOMAKE --add-missing
$AUTOCONF
-# configure once for fastdep, once for non-fastdep, once for nodep
+# Force dependency tracking explicitly, so that slow dependency
+# extractors are not rejected. Try also with dependency tracking
+# explicitly disabled.
for config_args in \
- '' \
- am_cv_CC_dependencies_compiler_type=gcc \
- --disable-dependency-tracking
+ --enable-dependency-tracking --disable-dependency-tracking
do
./configure $config_args --enable-silent-rules
diff --git a/tests/silent5.test b/tests/silent-many-gcc.test
similarity index 91%
copy from tests/silent5.test
copy to tests/silent-many-gcc.test
index 49039b8..d770a46 100755
--- a/tests/silent5.test
+++ b/tests/silent-many-gcc.test
@@ -14,13 +14,14 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-# Check silent-rules mode, languages other than C.
+# Check silent-rules mode, with gcc depmode and many languages at once.
# This test partly overlaps with other silent*.test, but it serves as
# a stress test by using many different languages at once -- so don't
# remove this test script.
+# This test requires the GNU compilers; keep it in sync with sister test
+# `silent-many-generic.test', which should work with generic compilers.
-# FIXME: generic C++/Fortran compilers should suffice here
-required='g++ gfortran flex bison'
+required='gcc g++ gfortran flex bison'
. ./defs || Exit 1
set -e
@@ -181,11 +182,11 @@ $ACLOCAL
$AUTOMAKE --add-missing
$AUTOCONF
-# configure once for fastdep, once for non-fastdep, once for nodep
+# Force gcc ("fast") depmode.
+# This apparently useless "for" loop is here to simplify the syncing
+# with sister test `silent-many-gcc.test'.
for config_args in \
- '' \
- am_cv_CC_dependencies_compiler_type=gcc \
- --disable-dependency-tracking
+ am_cv_CC_dependencies_compiler_type=gcc
do
./configure $config_args --enable-silent-rules
diff --git a/tests/silent5.test b/tests/silent-many-generic.test
similarity index 91%
rename from tests/silent5.test
rename to tests/silent-many-generic.test
index 49039b8..223a97c 100755
--- a/tests/silent5.test
+++ b/tests/silent-many-generic.test
@@ -14,10 +14,13 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-# Check silent-rules mode, languages other than C.
+# Check silent-rules mode, with many languages at once.
# This test partly overlaps with other silent*.test, but it serves as
# a stress test by using many different languages at once -- so don't
# remove this test script.
+# This test should work with generic compilers; keep it in sync with
+# sister test `silent-many-gcc.test', which requires the GNU compilers
+# and forces the use of gcc depmode.
# FIXME: generic C++/Fortran compilers should suffice here
required='g++ gfortran flex bison'
@@ -181,11 +184,11 @@ $ACLOCAL
$AUTOMAKE --add-missing
$AUTOCONF
-# configure once for fastdep, once for non-fastdep, once for nodep
+# Force dependency tracking explicitly, so that slow dependency
+# extractors are not rejected. Try also with dependency tracking
+# explicitly disabled.
for config_args in \
- '' \
- am_cv_CC_dependencies_compiler_type=gcc \
- --disable-dependency-tracking
+ --enable-dependency-tracking --disable-dependency-tracking
do
./configure $config_args --enable-silent-rules
diff --git a/tests/silentyacc.test b/tests/silent-yacc-gcc.test
similarity index 90%
copy from tests/silentyacc.test
copy to tests/silent-yacc-gcc.test
index d311e3d..33ae8ae 100755
--- a/tests/silentyacc.test
+++ b/tests/silent-yacc-gcc.test
@@ -14,9 +14,10 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-# Check silent-rules mode for Yacc.
+# Check silent-rules mode for Yacc, forcing gcc depmode.
+# Keep this in sync with sister test `silent-yacc-generic.test'.
-required='bison'
+required='gcc bison'
. ./defs || Exit 1
set -e
@@ -65,11 +66,11 @@ $ACLOCAL
$AUTOMAKE --add-missing
$AUTOCONF
-# configure once for fastdep, once for non-fastdep, once for nodep
+# Force gcc ("fast") depmode.
+# This apparently useless "for" loop is here to simplify the syncing
+# with sister test `silent-yacc-gcc.test'.
for config_args in \
- '' \
- am_cv_CC_dependencies_compiler_type=gcc \
- --disable-dependency-tracking
+ am_cv_CC_dependencies_compiler_type=gcc
do
./configure $config_args --enable-silent-rules
diff --git a/tests/silentyacc.test b/tests/silent-yacc-generic.test
similarity index 92%
rename from tests/silentyacc.test
rename to tests/silent-yacc-generic.test
index d311e3d..b7489da 100755
--- a/tests/silentyacc.test
+++ b/tests/silent-yacc-generic.test
@@ -15,6 +15,7 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# Check silent-rules mode for Yacc.
+# Keep this in sync with sister test `silent-yacc-gcc.test'.
required='bison'
. ./defs || Exit 1
@@ -65,11 +66,11 @@ $ACLOCAL
$AUTOMAKE --add-missing
$AUTOCONF
-# configure once for fastdep, once for non-fastdep, once for nodep
+# Force dependency tracking explicitly, so that slow dependency
+# extractors are not rejected. Try also with dependency tracking
+# explicitly disabled.
for config_args in \
- '' \
- am_cv_CC_dependencies_compiler_type=gcc \
- --disable-dependency-tracking
+ --enable-dependency-tracking --disable-dependency-tracking
do
./configure $config_args --enable-silent-rules
hooks/post-receive
--
GNU Automake
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Automake-commit] [SCM] GNU Automake branch, maint, updated. v1.11-247-gfdb2764,
Stefano Lattarini <=