[automake-commit] branch master updated: bug#40699: "dist Hook" documentation in manual is incorrect or unclear about write permissions

[Karl Berry]

This is an automated email from the git hooks/post-receive script.

karl pushed a commit to branch master
in repository automake.

View the commit online:
https://git.savannah.gnu.org/gitweb/?p=automake.git;a=commitdiff;h=c211745ed4b384a9329d779c2235c3c23ccce5fa

The following commit(s) were added to refs/heads/master by this push:
     new c211745  bug#40699: "dist Hook" documentation in manual is incorrect 
or unclear about write permissions
c211745 is described below

commit c211745ed4b384a9329d779c2235c3c23ccce5fa
Author: Vincent Lefevre <address@hidden>
AuthorDate: Thu Apr 23 17:40:39 2020 +0200

    bug#40699: "dist Hook" documentation in manual is incorrect or unclear 
about write permissions
    
    On 2020-04-20 14:59:00 -0600, Karl Berry wrote:
    >     i.e. it does not change the permissions in order to make the removal
    >     work recursively
    >
    > Right, I see it now. Had been testing the wrong thing.
    >
    > So, can you propose a specific change for the manual? -k
    
    I think that it is sufficient to fix the example (the explanation
    is just below). BTW, the second example is also incorrect.
    
    commit a639e5b51cadbaff88ca4059b4db4571c811070c
    Author: Vincent Lefevre <address@hidden>
    Date:   2020-04-23 17:33:54 +0200
    
        doc: fix dist-hook examples
---
 doc/automake.texi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/doc/automake.texi b/doc/automake.texi
index 469a729..1b35883 100644
--- a/doc/automake.texi
+++ b/doc/automake.texi
@@ -8497,6 +8497,7 @@ a directory in @code{EXTRA_DIST}:
 @example
 EXTRA_DIST = doc
 dist-hook:
+        chmod -R u+w $(distdir)/doc
         rm -rf `find $(distdir)/doc -type d -name .svn`
 @end example
 
@@ -8516,7 +8517,7 @@ distribution directory, it should explicitly to make it 
writable first:
 EXTRA_DIST = README doc
 dist-hook:
         chmod u+w $(distdir)/README $(distdir)/doc
-        echo "Distribution date: `date`" >> README
+        echo "Distribution date: `date`" >> $(distdir)/README
         rm -f $(distdir)/doc/HACKING
 @end example