[automake-commit] branch master updated: tests: recompute dependencies when lists-of-tests.mk changes.

[Karl Berry]

This is an automated email from the git hooks/post-receive script.

karl pushed a commit to branch master
in repository automake.

View the commit online:
https://git.savannah.gnu.org/gitweb/?p=automake.git;a=commitdiff;h=285c285c5b79b65d8fab86ca6d15bd8d8bccacbc

The following commit(s) were added to refs/heads/master by this push:
     new 285c285  tests: recompute dependencies when lists-of-tests.mk changes.
285c285 is described below

commit 285c285c5b79b65d8fab86ca6d15bd8d8bccacbc
Author: Karl Berry <karl@freefriends.org>
AuthorDate: Sat Nov 7 18:11:03 2020 -0800

    tests: recompute dependencies when lists-of-tests.mk changes.
    
    This change fixes https://bugs.gnu.org/44458
    and updates https://bugs.gnu.org/11347.
    
    * t/local.mk ($(srcdir)/%D/testsuite-part.am): restore
    dependency on '%D/list-of-tests.mk' (i.e., t/list-of-tests.mk),
    partially reverting the change of 26 Apr 2012 for bug#11347.
    Otherwise, new tests that have dependencies will not cause an
    update of testsuite-part.am, leading to strange failures
    (bug#44458). The original problem being fixed in #11347 was
    unnecessary rebuilding when modifying tests; that should not be
    affected here, but when new tests are added, it seems reasonable,
    as well as necessary, to ensure dependencies are updated.
---
 t/local.mk | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/t/local.mk b/t/local.mk
index bd1615e..51fd864 100644
--- a/t/local.mk
+++ b/t/local.mk
@@ -91,12 +91,13 @@ $(srcdir)/%D%/testsuite-part.am:
        $(AM_V_at)mv -f %D%/testsuite-part.tmp $@
 EXTRA_DIST += gen-testsuite-part
 
-# The dependecies declared here are not truly complete, but such
+# The dependencies declared here are not truly complete, but such
 # completeness would cause more issues than it would solve.  See
-# automake bug#11347.
+# automake bug#11347 and #44458.
 $(generated_TESTS): $(srcdir)/gen-testsuite-part
 $(srcdir)/%D%/testsuite-part.am: $(srcdir)/gen-testsuite-part
 $(srcdir)/%D%/testsuite-part.am: Makefile.am
+$(srcdir)/%D%/testsuite-part.am: %D%/list-of-tests.mk
 
 # Hand-written tests for stuff in 'contrib/'.
 include $(srcdir)/contrib/%D%/local.mk