Re: install-strip target does not work when using nobase_ prefix

[Alexandre Duret-Lutz]

>>> "Elmar" == Elmar Hoffmann <address@hidden> writes:

[...]
 Elmar> nobase_binPROGRAMS_INSTALL = $(install_sh_PROGRAM)
[...]
 Elmar> install-strip:
 Elmar> $(MAKE) $(AM_MAKEFLAGS) INSTALL_PROGRAM="$(INSTALL_STRIP_PROGRAM)" \
 Elmar> INSTALL_STRIP_FLAG=-s \
 Elmar> `test -z '$(STRIP)' || \
 Elmar> echo "INSTALL_PROGRAM_ENV=STRIPPROG='$(STRIP)'"` install

 Elmar> install_sh_PROGRAM remains defined to the default which does not strip
 Elmar> the executables.

Good catch, thanks!  I'm installing the following patch on HEAD
and branch-1-7.

2003-10-21  Alexandre Duret-Lutz  <address@hidden>

        * lib/am/install.am (install-strip): Override install_sh_PROGRAM
        too.
        Report from Elmar Hoffmann.

Index: THANKS
===================================================================
RCS file: /cvs/automake/automake/THANKS,v
retrieving revision 1.186.2.34
diff -u -r1.186.2.34 THANKS
--- THANKS      6 Oct 2003 21:47:51 -0000       1.186.2.34
+++ THANKS      21 Oct 2003 13:03:29 -0000
@@ -51,6 +51,7 @@
 Doug Evans             address@hidden
 Duncan Gibson          address@hidden
 Eleftherios Gkioulekas address@hidden
+Elmar Hoffmann         address@hidden
 Elrond                 address@hidden
 Enrico Scholz          address@hidden
 Erez Zadok             address@hidden
Index: lib/am/install.am
===================================================================
RCS file: /cvs/automake/automake/lib/am/install.am,v
retrieving revision 1.10.2.2
diff -u -r1.10.2.2 install.am
--- lib/am/install.am   17 May 2003 11:32:32 -0000      1.10.2.2
+++ lib/am/install.am   21 Oct 2003 13:03:31 -0000
@@ -65,9 +65,16 @@
 ## directory.
 .PHONY: install-strip
 install-strip:
+## Beware that they are two variables used to install programs:
+##   INSTALL_PROGRAM is used for ordinary *_PROGRAMS
+##   install_sh_PROGRAM us used for nobase_*_PROGRAMS (because install-sh
+##                                                     creates directories)
+## It's OK to override both with INSTALL_STRIP_PROGRAM, because
+## INSTALL_STRIP_PROGRAM uses install-sh (see m4/strip.m4 for a rational).
+##
 ## Use double quotes here because we might need to interpolate some
 ## backquotes at runtime.
        $(MAKE) $(AM_MAKEFLAGS) INSTALL_PROGRAM="$(INSTALL_STRIP_PROGRAM)" \
-         INSTALL_STRIP_FLAG=-s \
+         install_sh_PROGRAM="$(INSTALL_STRIP_PROGRAM)" INSTALL_STRIP_FLAG=-s \
          `test -z '$(STRIP)' || \
            echo "INSTALL_PROGRAM_ENV=STRIPPROG='$(STRIP)'"` install
-- 
Alexandre Duret-Lutz