[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Support AC_CONFIG_LIBOBJ_DIR
From: |
Paul Eggert |
Subject: |
Re: [PATCH] Support AC_CONFIG_LIBOBJ_DIR |
Date: |
Mon, 18 Apr 2005 12:59:41 -0700 |
User-agent: |
Gnus/5.1006 (Gnus v5.10.6) Emacs/21.4 (gnu/linux) |
I like the patch from the Autoconf point of view, assuming the Automake
folks take their bit. One small point:
"Gary V. Vaughan" <address@hidden> writes:
> +ac_libobj_dir=
> +test "X${ac_config_libobj_dir-.}" != X. &&
> + ac_libobj_dir=`echo "$ac_config_libobj_dir/" | sed 's,/*$,/,'`
That would mishandle the case where ac_config_libobj_dir consists
entirely of slashes, or if it contains weird characters like
backslashes or newlines in unusual positions. Is this possible? If
so, how about something like this to avoid the problem?
ac_libobj_dir=
test "X${ac_config_libobj_dir-.}" != X. &&
ac_libobj_dir=`expr "X$ac_config_libobj_dir/" : 'X\(.*[^/]\)' '|' 'X/' :
'X\(/\)'`
- [PATCH] Support AC_CONFIG_LIBOBJ_DIR, Gary V. Vaughan, 2005/04/18
- Re: [PATCH] Support AC_CONFIG_LIBOBJ_DIR, Gary V. Vaughan, 2005/04/18
- Re: [PATCH] Support AC_CONFIG_LIBOBJ_DIR,
Paul Eggert <=
- Re: [PATCH] Support AC_CONFIG_LIBOBJ_DIR, Alexandre Duret-Lutz, 2005/04/18
- Re: [PATCH] Support AC_CONFIG_LIBOBJ_DIR, Gary V. Vaughan, 2005/04/20
- Re: [PATCH] Support AC_CONFIG_LIBOBJ_DIR (fixes PR/401), Gary V. Vaughan, 2005/04/20
- Re: [PATCH] Support AC_CONFIG_LIBOBJ_DIR (fixes PR/401), Paul Eggert, 2005/04/20
- Re: [PATCH] Support AC_CONFIG_LIBOBJ_DIR (fixes PR/401), Alexandre Duret-Lutz, 2005/04/21
- Re: [PATCH] Support AC_CONFIG_LIBOBJ_DIR (fixes PR/401), Gary V. Vaughan, 2005/04/25