[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: depcomp testing
From: |
Ralf Wildenhues |
Subject: |
Re: depcomp testing |
Date: |
Sun, 19 Mar 2006 06:46:24 +0100 |
User-agent: |
Mutt/1.5.9i |
* Alexandre Duret-Lutz wrote on Sat, Mar 18, 2006 at 07:28:14AM CET:
> >>> "RW" == Ralf Wildenhues <address@hidden> writes:
>
> The extra test look useful even without this point, so please go
> ahead and check them.
Thanks. Applied with your comments addressed.
> RW> + sleep 1
>
> Just use $sleep (see tests/defs.in).
>
> make maintainer-check should probably warn about this, although I haven't run
> it for a while
It does warn. I simply did not know maintainer-check.
> Let's write "$MAKE && exit 1" because that's what of the other test do, and
> I'm wary that some shell will return the $? of $MAKE if it fails, in turn
> causing "set -e" to abort the script. Don't ask me which shell, but that's
> why we have "else :; fi" all over the Makefiles.
I always thought that was because of the `sh -e -c "$cmd"' that some
make implementations used (see Autoconf portability section).
Cheers,
Ralf