[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: pr401*.test and BSD make: computing LIBOBJDIR
From: |
Ralf Wildenhues |
Subject: |
Re: pr401*.test and BSD make: computing LIBOBJDIR |
Date: |
Wed, 7 Jun 2006 11:34:09 +0200 |
User-agent: |
Mutt/1.5.11 |
* Alexandre Duret-Lutz wrote on Tue, Jun 06, 2006 at 09:09:02PM CEST:
> >>> "adl" == Alexandre Duret-Lutz <address@hidden> writes:
>
> adl> I'll try to look at this and the rewrite of depout later this week-end
>
> Ahem... I had a very long week. (Does that sound credible?)
Naa, but that doesn't matter.
> Sorry about that.
Don't worry.
> >>> "RW" == Ralf Wildenhues <address@hidden> writes:
>
> RW> To fix this, we need to munge a bit in _AM_OUTPUT_DEPENDENCY_COMMANDS so
> RW> that `am__include $(top_builddir)/...' will also be understood correctly.
> RW> Note here that it seems necessary to go to lengths to extract
> RW> top_builddir, because by the time `config.status' instantiates depfiles,
> RW> the value of $ac_top_build_prefix will be `.', which is not what we
> RW> need. (Maybe Autoconf should help out here? Dunno; the way I did
> RW> surely is expensive, as it adds a fork per Makefile, to fix a corner
> RW> case.)
>
> $(top_builddir) can be computed statically by Automake if
> needed. I think automake's $topsrcdir (the Perl variable)
> contains exactly the relative path you want. Maybe that's
> simpler and faster ? (i.e., no depout.m4 modification required)
I'll look into that.
> RW> * automake.in (handle_LIBOBJS_or_ALLOCA): With subdir-objects,
> RW> do not prefix `$(top_builddir)/' aka `./' to nonempty LIBOBJDIR,
> RW> to help BSD Make find the files also in a VPATH build.
> RW> Also return the same path, possibly prefixed, for correct
> RW> depdir computation.
>
> Took me a while to realize that the chunk changing depdir's
> computation was missing from the patch you sent.
What was missing from my patch? It's been a while, but I don't recall
the patch being incomplete in any sense; I documented the parts of the
report that it fixes.
(And of course it should be `OSF make' instead of `BSD make'...)
Cheers,
Ralf