Re: [cygwin] Analysis for new testsuite failures 33,34.35

[Ralf Wildenhues]

Hi Charles,

Thanks for the bug report.

* Charles Wilson wrote on Fri, Mar 23, 2007 at 07:32:12AM CET:
> 
> ../../libtool-HEAD/tests/subproject.at:56: $MAKE all $tst_dist
> + make all dist
[...]
> mkdir: cannot create directory 
> `/usr/src/libtool/cvs/_build/tests/testsuite.dir/33/subproject-demo-2.1a/sub/ltdl':
>  
> File exists
> make[2]: *** [distdir] Error 1

AFAICS, this can only happen if libltdl was treated with automake-1.9
and the tests run with automake-1.10 in place, so that the toplevel
package (named subproject-demo-2.1a) is treated with 1.10.

Hmm.  This is kind of a backward incompatibility, unfortunately.
It can be helped by using the same Automake version for both
bootstrapping and testing, or by using 1.10 for libltdl.

[...]
> Now, I'm not sure how to "solve" this problem: I don't know what the policy 
> is on the required version of automake for libtool-HEAD, but I'm pretty sure 
> it isn't "require 1.10".  But I also don't know if automake-1.9.x is still 
> under development, and would accept the above backport for some future 
> automake-1.9.7 release.

Alexandre said he did not want to continue 1.9.  If there were to be
another point release, this patch would certainly be a good candidate
IMHO.  For reference, below's the patch including ChangeLog entry.

Cheers,
Ralf

2007-03-26  Charles Wilson  <...>

        * lib/am/distdir.am (distdir): Do not fail if $(distdir) already
        exists, for forward compatibility with Automake 1.10 that
        overrides the removal due to $(am__remove_distdir).  Fixes `make
        dist' failures in which the toplevel package uses 1.10, but a
        subpackage 1.9 only.

Index: lib/am/distdir.am
===================================================================
RCS file: /cvs/automake/automake/lib/am/distdir.am,v
retrieving revision 1.60.2.1
diff -u -r1.60.2.1 distdir.am
--- lib/am/distdir.am   14 May 2005 20:29:20 -0000      1.60.2.1
+++ lib/am/distdir.am   26 Mar 2007 18:36:36 -0000
@@ -1,5 +1,5 @@
 ## automake - create Makefile.in from Makefile.am
-## Copyright (C) 2001, 2002, 2003, 2004  Free Software Foundation, Inc.
+## Copyright (C) 2001, 2002, 2003, 2004, 2007  Free Software Foundation, Inc.
 
 ## This program is free software; you can redistribute it and/or modify
 ## it under the terms of the GNU General Public License as published by
@@ -50,7 +50,7 @@
 ##
 if %?TOPDIR_P%
        $(am__remove_distdir)
-       mkdir $(distdir)
+       test -d $(distdir) || mkdir $(distdir)
 endif %?TOPDIR_P%
 ##
 ##