Re: [PATCH 2/2] Avoid an unportable use of `$status' shell variable.

[Stefano Lattarini]

At Tuesday 30 March 2010, Ralf Wildenhues <address@hidden> wrote:
> * Stefano Lattarini wrote on Tue, Mar 30, 2010 at 05:54:03PM CEST:
> > * Makefile.am (path-check): Don't use the `$status' shell
> > variable in the target's rules, as it's special in Zsh
> > (equivalent to `$?', and readonly).
> 
> Thanks!  Will push.
> 
> A very minor nit:
> > --- a/ChangeLog
> > +++ b/ChangeLog
> > @@ -1,5 +1,13 @@
> >  2010-03-30  Stefano Lattarini  <address@hidden>
> >
> > +   Avoid an unportable use of `$status' shell variable.
> > +
> > +   * Makefile.am (path-check): Don't use the `$status' shell
> > variable
> 
> For future patches, please remove the empty line between summary
>  line and rest, it's customary to not have it in the ChangeLog, and
>  only really needed in the git log, for nice 'git log --oneline'
>  output.
You're right.  This time I cut from the git commit message and copied
to the ChangeLog, rather than the other way round, as I usually do.
I'll try be more careful in the future.

> > +   in the target's rules, as it's special in Zsh (equivalent to `$?',
> > +   and readonly).
> > +
> > +2010-03-30  Stefano Lattarini  <address@hidden>
> > +
> 
>  Another minor nit: I usually merge two patches on the same day to
>  have only one author header line.  Some projects do it this way,
>  some the other.  I think GCS recommends it.
And in fact there are some instances of this formatting in the
ChangeLog file, so I could have got it right without being told.

Sorry for the sloppy mistakes, I'll try do better in the future.

Thank you for the review and the advices,
     Stefano