[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] Use `set -e' in confsub.test (avoid false negatives).
From: |
Stefano Lattarini |
Subject: |
Re: [PATCH 1/2] Use `set -e' in confsub.test (avoid false negatives). |
Date: |
Sun, 11 Apr 2010 20:47:00 +0200 |
User-agent: |
KMail/1.12.1 (Linux/2.6.30-2-686; KDE/4.3.2; i686; ; ) |
At Sunday 11 April 2010, Ralf Wildenhues <address@hidden>
wrote:
> Hello Stefano,
>
> * Stefano Lattarini wrote on Fri, Apr 09, 2010 at 07:25:31PM CEST:
> > -$ACLOCAL || Exit 1
> > -$AUTOMAKE || Exit 1
> > +$ACLOCAL
> > +$AUTOMAKE
>
> there is no need to actually remove these.
Strictly speaking, no; but their removal would make the script more
consistent with the great majority of the other tests which use
`set -e'.
Anyway, I'm fine with keeping those `|| Exit', since the "consistency"
I'm speaking about here is purely cosmetic, bordering on pointless
nitpicking (on the contrary, the use `set -e' concerns IMO semantic
consistency, which is far far more important).
> They may not be
> strictly required any more with 'set -e', but they may still serve
> as visual reminder that this is an important part of the test.
Thanks,
Stefano