[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 8/9] Tests on extensibility of silent-rules made stricter.
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH 8/9] Tests on extensibility of silent-rules made stricter. |
Date: |
Mon, 26 Apr 2010 07:34:52 +0200 |
User-agent: |
Mutt/1.5.20 (2009-10-28) |
* Stefano Lattarini wrote on Mon, Apr 26, 2010 at 12:15:33AM CEST:
> --- a/tests/silent6.test
> +++ b/tests/silent6.test
> @@ -99,5 +99,3 @@ $AUTOMAKE
> grep 'AM_V_GEN' Makefile.in
> $AUTOMAKE --force -Wno-all -Wportability
> grep 'AM_V_GEN' Makefile.in
> -
> -:
Please don't remove trailing ':' or 'Exit 0'. They exist for a reason:
when somebody changes the test by adding a failing command after the
last command, the test will spuriously fail because $? is nonzero at the
end. Keeping a trailing ':' prevents that. (And no, please also don't
newly introduce these things just for the heck of it either (i.e., when
you wouldn't otherwise be editing the test), that's not the point.)
Thanks,
Ralf
- Re: [PATCH 3/9] New test silentyacc.test (Automake/Yacc silent-mode)., (continued)
- [PATCH 4/9] New test silentcxx.test (Automake/C++ silent-mode)., Stefano Lattarini, 2010/04/25
- [PATCH 5/9] New tests for Automake silent-mode with Fortran., Stefano Lattarini, 2010/04/25
- Subject: [PATCH 6/9] Improved test silent5.test., Stefano Lattarini, 2010/04/25
- [PATCH 7/9] Tests on silent-mode for C/Libtool made stricter., Stefano Lattarini, 2010/04/25
- [PATCH 8/9] Tests on extensibility of silent-rules made stricter., Stefano Lattarini, 2010/04/25
- Re: [PATCH 8/9] Tests on extensibility of silent-rules made stricter.,
Ralf Wildenhues <=
- Re: [PATCH 8/9] Tests on extensibility of silent-rules made stricter., Stefano Lattarini, 2010/04/26
[PATCH 9/9] Tiny fix in silent8.test (display output of `make' command)., Stefano Lattarini, 2010/04/25