[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Enable `errexit' shell flag in some test scripts.
From: |
Stefano Lattarini |
Subject: |
Re: [PATCH] Enable `errexit' shell flag in some test scripts. |
Date: |
Sun, 6 Jun 2010 18:10:00 +0200 |
User-agent: |
KMail/1.12.1 (Linux/2.6.30-2-686; KDE/4.3.4; i686; ; ) |
At Sunday 06 June 2010, Ralf Wildenhues <address@hidden>
wrote:
> Hi Stefano,
>
> > The involved test scripts and the modifications done to them are
> > simple enough that no portability problem involving the `errexit'
> > flag should have been introduced.
>
> Not quite right in this case. OpenBSD sh fails ext.test with your
> patch, see my recent post on autoconf-patches which should improve
> the autoconf.texi description of this issue.
Thanks, I'll keep that in mind in the future.
Anyway, a false positive is not such a big problem (even if it's
definitely annoying); I'm more concerned about the possibility to
introduce false negatives with my changes. Luckily, your careful
reviews can really help here.
Regards,
Stefano