Re: cond5.test spurious failure

[Stefano Lattarini]

Hi Peter.  It seems our patches crossed...

At Friday 06 August 2010, Peter Rosin wrote:
> As seen above, kill seems to always work once it starts to work,
> so I tried to insert a sleep before the first kill. That "fixes"
> it. I have 10+ consecutive successes, no fails.
> 
> Please apply this on top of maint:
> 
> Cheers,
> Peter

> diff --git a/tests/cond5.test b/tests/cond5.test
> index 84afdd0..88e2e42 100755
> --- a/tests/cond5.test
> +++ b/tests/cond5.test
> @@ -48,6 +48,9 @@ $ACLOCAL
>  $AUTOMAKE 2>stderr &
>  pid=$!
> 
> +# MSYS bash seems to have a bug in kill, so don't try to kill too soon.
> +sleep 2
> +
>  # Make at most 30 tries, one every 10 seconds (= 300 seconds = 5 min).
>  try=1
>  while test $try -le 30; do
Your patch is defintely simpler, but I still prefer mine (well, I will
if it works ;-), since it is also more "theoretically" correct.

If my patch works also on MSYS, do you have any objections to it?

Regards,
  Stefano