[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Modernize, improve and extend tests `subobj*.test'.
From: |
Stefano Lattarini |
Subject: |
Re: [PATCH] Modernize, improve and extend tests `subobj*.test'. |
Date: |
Sun, 8 Aug 2010 13:33:54 +0200 |
User-agent: |
KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) |
At Sunday 08 August 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Sun, Aug 08, 2010 at 12:44:32PM CEST:
> > At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > > > -$FGREP 'generic/a.$(OBJEXT)' Makefile.in
> > > > +grep '^generic/a\.\$(OBJEXT):' Makefile.in
> > >
> > > Some day I'll add initial and trailing space to the target
> > > names of all generated rules to see how portable our test
> > > suite is ... ;-)
> >
> > I assume the change is OK, though... is it?
>
> Are you trying to resurrect the discussion about whether tests
> should exploit internal details more than necessary?
Nope, I was confused by the ";-)" at the end. If you tell that
this change forces too much internal details to be exposed, I'll
revert it (to be more explicit: now it's clear you've told that,
so I'm going to revert this change right away).
Regards,
Stefano