Re: [PATCH 2/4] {branch "tests-init"} Tests defs: new variable $top_srcdir.

[Ralf Wildenhues]

* Stefano Lattarini wrote on Fri, Sep 03, 2010 at 12:24:12AM CEST:
> * tests/defs.in ($top_srcdir): Define unconditionally
> to @address@hidden  Use it throughout.
> * tests/ar-lib.test: Use `$top_srcdir' instead of
> `$testsrcdir/..'.
> * tests/auxdir.test: Likewise.
> * tests/compile.test: Likewise.
> * tests/compile2.test: Likewise.
> * tests/compile3.test: Likewise.
> * tests/compile5.test: Likewise.
> * tests/mdate6.test: Likewise.
> * tests/mkinst3.test: Likewise.
> * tests/multlib.test: Likewise.
> * tests/txinfo22.test: Likewise.

I'm not sure I understand why you first rename testsrcdir to top_srcdir
just to then rename it again.  Why not rename it to the final name right
away?  That would also alleviate any fears that top_srcdir could
influence testsuite results (I don't see your patch exporting the
variable, but it may have been exported elsewhere, or before).

Other than that, the flattened changes 2-4/4 look fine, thanks.
(I haven't checked whether you caught all instances of the variables.)

Cheers,
Ralf