[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: More problems with `make -n' in automake-generated rules.
From: |
Ralf Wildenhues |
Subject: |
Re: More problems with `make -n' in automake-generated rules. |
Date: |
Wed, 10 Nov 2010 19:20:36 +0100 |
User-agent: |
Mutt/1.5.20 (2010-08-04) |
* Ralf Wildenhues wrote on Mon, Nov 01, 2010 at 10:18:55PM CET:
> Fix and document rules to not touch the tree with `make -n'.
>
> * doc/automake.texi (Multiple Outputs): Document the problem of
> modifications during dry-run execution, propose solution.
> * NEWS: Update.
> * automake.in (lang_vala_finish_target): Split recipe so the
> stamp file is not removed with GNU `make -n'.
> (lang_yacc_target_hook): Separate removal of parser output file
> and header remaking.
> * lib/am/lisp.am ($(am__ELCFILES)): Determine whether -n was
> passed to make, take care not to remove any files in that case.
> * lib/am/remake-hdr.am (%CONFIG_H%): Separate removal of
> %STAMP% file from induced remaking of config header.
> * tests/autohdrdry.test, tests/lispdry.test, tests/yaccdry.test:
> New tests.
> * tests/Makefile.am (TESTS): Update.
This test needed a fixup, as yaccdry requires nonempty $YACC.
Found by the NixOS Hydra, kudos to them!
http://hydra.nixos.org/build/741504
The test could probably also be written without requiring bison
(make -t or so), but I'd prefer to have the setup be realistic,
that's more important than having coverage on every system out there.
Pushed to maint.
Thanks,
Ralf
Fix yaccdry.test failure: require bison.
* tests/yaccdry.test: Require bison.
Found by NixOS Hydra.
diff --git a/tests/yaccdry.test b/tests/yaccdry.test
index d11d3fe..d2e7632 100755
--- a/tests/yaccdry.test
+++ b/tests/yaccdry.test
@@ -16,6 +16,7 @@
# Removal recovery rules for headers should not remove files with `make -n'.
+required=bison
. ./defs || Exit 1
set -e
- Re: More problems with `make -n' in automake-generated rules., (continued)
Re: More problems with `make -n' in automake-generated rules., Stefano Lattarini, 2010/11/03
Re: More problems with `make -n' in automake-generated rules., Stefano Lattarini, 2010/11/06
Re: More problems with `make -n' in automake-generated rules.,
Ralf Wildenhues <=
[PATCH] tests/yaccdry.test ($required): Require bison. (was: Re: More problems with `make -n' in automake-generated rules.), Stefano Lattarini, 2010/11/14