[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE.
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE. |
Date: |
Fri, 14 Jan 2011 07:11:09 +0100 |
User-agent: |
Mutt/1.5.20 (2010-08-04) |
* Stefano Lattarini wrote on Thu, Jan 13, 2011 at 10:27:48PM CET:
> On Thursday 13 January 2011, Ralf Wildenhues wrote:
> > * Stefano Lattarini wrote on Wed, Jan 12, 2011 at 09:11:41PM CET:
> > > On Wednesday 12 January 2011, Ralf Wildenhues wrote:
> > > > So, now with that said, I'm not sure whether I should approve this
> > > > patch. What do you think?
> > > >
> > > I think that you should, provided that I add the sanity check you
> > > suggested above.
> >
> > OK.
> >
> Hmm... Wait, this sanity check is OK only starting from [PATCH 7/9]
> onward, as until then the 'handle_options()' subroutine still calls
> 'process_option_list()' multiple times (that's why the bug is still
> present for AUTOMAKE_OPTIONS at this point).
>
> So, OK to add the sanity check in [PATCH 7/9] (or in a new follow-up
> patch to be placed between patches 7 and 8 in this series)?
Well yes, but why not show the check diff if you have it already?
Thanks,
Ralf
- [PATCH 2/9] New test on silent-rules mode and portability warnings., (continued)
- [PATCH 2/9] New test on silent-rules mode and portability warnings., Stefano Lattarini, 2011/01/04
- [PATCH 3/9] Warnings win over strictness on command line., Stefano Lattarini, 2011/01/04
- [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE., Stefano Lattarini, 2011/01/04
- Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE., Ralf Wildenhues, 2011/01/05
- Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE., Stefano Lattarini, 2011/01/05
- Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE., Ralf Wildenhues, 2011/01/06
- Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE., Ralf Wildenhues, 2011/01/12
- Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE., Stefano Lattarini, 2011/01/12
- Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE., Ralf Wildenhues, 2011/01/13
- Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE., Stefano Lattarini, 2011/01/13
- Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE.,
Ralf Wildenhues <=
- Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE., Stefano Lattarini, 2011/01/14
- Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE., Stefano Lattarini, 2011/01/13
- Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE., Ralf Wildenhues, 2011/01/14
- Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE., Stefano Lattarini, 2011/01/14
[PATCH 5/9] Add more tests about AUTOMAKE_OPTIONS., Stefano Lattarini, 2011/01/04
[PATCH 6/9] Change signature of 'Automake::Options::_process_option_list()'., Stefano Lattarini, 2011/01/04
[PATCH 7/9] Warnings win over strictness in AUTOMAKE_OPTIONS., Stefano Lattarini, 2011/01/04