[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE.
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE. |
Date: |
Fri, 14 Jan 2011 07:14:51 +0100 |
User-agent: |
Mutt/1.5.20 (2010-08-04) |
* Stefano Lattarini wrote on Fri, Jan 14, 2011 at 12:11:27AM CET:
> [Ralf Wildenhues]
> > > > If some code later calls it like
> > > > process_option_list (first-set-of-options);
> > > > process_option_list (second-set-of-options);
> > > >
> > > > then things will go wrong again. I suspect that it will mean that
> > > > AM_INIT_AUTOMAKE([foreign -Wno-portability])
> > > > AUTOMAKE_OPTIONS = gnu
> > > >
> > > > won't do what we want. Hmm. What exactly is it that we want to happen
> > > > in this case? Should gnu override -Wno-portability if specified in a
> > > > (to-be) higher order place?
> > > >
> [Stefano Lattarini]
> > > I assumed without saying that yes, this was to be the intended behaviour.
> > > And I still think it should be. Sorry for not having been explicit about
> > > that before.
> [Ralf Wildenhues]
> >
> > I agree that it should be, but this, too, should be documented (in
> > autoconf.texi and maybe also NEWS) and tested, when it works.
> >
> What about the attached patch? It also adds a test for another situation
> I hadn't thought about previously.
>
> OK to apply the patch in a new commit between [PATCH 2/9] and [PATCH 3/9]?
Well yes, but why omit the documentation bits that I asked for?
(efficient communication, and all that)
Thanks,
Ralf
> Subject: [PATCH] More tests on warnings and strictness.
>
> * tests/warnings-strictness-interactions.test: New test.
> * tests/warnings-unknown.test: Likewise.
> * tests/Makefile.am (TESTS): Update.
- Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE., (continued)
- Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE., Ralf Wildenhues, 2011/01/05
- Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE., Stefano Lattarini, 2011/01/05
- Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE., Ralf Wildenhues, 2011/01/06
- Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE., Ralf Wildenhues, 2011/01/12
- Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE., Stefano Lattarini, 2011/01/12
- Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE., Ralf Wildenhues, 2011/01/13
- Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE., Stefano Lattarini, 2011/01/13
- Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE., Ralf Wildenhues, 2011/01/14
- Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE., Stefano Lattarini, 2011/01/14
- Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE., Stefano Lattarini, 2011/01/13
- Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE.,
Ralf Wildenhues <=
- Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE., Stefano Lattarini, 2011/01/14
[PATCH 5/9] Add more tests about AUTOMAKE_OPTIONS., Stefano Lattarini, 2011/01/04
[PATCH 6/9] Change signature of 'Automake::Options::_process_option_list()'., Stefano Lattarini, 2011/01/04
[PATCH 7/9] Warnings win over strictness in AUTOMAKE_OPTIONS., Stefano Lattarini, 2011/01/04
[PATCH 8/9] Update NEWS about the warnings-over-strictness precedence., Stefano Lattarini, 2011/01/04