[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
tests: always update generated tests silently
From: |
Ralf Wildenhues |
Subject: |
tests: always update generated tests silently |
Date: |
Sat, 15 Jan 2011 09:36:30 +0100 |
User-agent: |
Mutt/1.5.20 (2010-08-04) |
Reading the log files, I notice that I forgot to use
--enable-silent-rules throughout, so that all the test generation is
done verbosely and a bit annoying when reading the log files. Now, even
if I won't forget again, our users likely will. Would you mind just
generating them completely silently by default?
Alternatively, we could prefix them with
@$(AM_V_GEN)
@$(AM_V_at)
...
then in silent-rules mode the GEN line would still be output.
Or should we go the next step and use AM_SILENT_RULES([yes])?
What do you think?
Thanks,
Ralf
tests: always update generated tests silently
* tests/Makefile.am ($(parallel_tests), $(instspc_tests)):
Always generate silently, not just in silent-rules mode.
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 0a57967..d50fb59 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -35,8 +35,8 @@ $(srcdir)/parallel-tests.am: gen-parallel-tests Makefile.am
$(AM_V_GEN)($(am__cd) $(srcdir) && $(SHELL) ./gen-parallel-tests) >$@
$(parallel_tests): Makefile.am
- $(AM_V_at)rm -f $@ address@hidden
- $(AM_V_GEN)input=`echo $@ | sed 's,.*/,,; s,-p.test$$,.test,'`; \
+ @rm -f $@ address@hidden
+ @input=`echo $@ | sed 's,.*/,,; s,-p.test$$,.test,'`; \
{ echo '#!/bin/sh'; \
echo '# DO NOT EDIT! GENERATED AUTOMATICALLY!'; \
echo; \
@@ -54,7 +54,7 @@ $(parallel_tests): Makefile.am
echo " . \"\$$testsrcdir/$$input\""; \
echo 'fi'; \
} > address@hidden
- $(AM_V_at)chmod a+rx address@hidden && mv -f address@hidden $@
+ @chmod a+rx address@hidden && mv -f address@hidden $@
MAINTAINERCLEANFILES += $(parallel_tests)
EXTRA_DIST += gen-parallel-tests
@@ -67,8 +67,8 @@ $(srcdir)/instspc-tests.am: instspc-tests.sh Makefile.am
&& $(SHELL) ./instspc-tests.sh --generate-makefile) >$@
$(instspc_tests): Makefile.am
- $(AM_V_at)rm -f $@ address@hidden
- $(AM_V_GEN) :; \
+ @rm -f $@ address@hidden
+ @:; \
base=`expr 'x/$@' : 'x.*/instspc-\(.*\)\.test$$'`; \
name=`expr x"$$base" : x'\(.*\)-'`; \
action=`expr x"$$base" : x'.*-\(.*\)'`; \
@@ -84,7 +84,7 @@ $(instspc_tests): Makefile.am
echo "instspc_action='test-$$action'"; \
echo ". \$$testsrcdir/instspc-tests.sh"; \
} > address@hidden
- $(AM_V_at)chmod a+rx address@hidden && mv -f address@hidden $@
+ @chmod a+rx address@hidden && mv -f address@hidden $@
# All instspc*.test tests work by sourcing the instspc-tests.sh script.
$(instspc_tests:.test=.log): instspc-tests.sh
- tests: always update generated tests silently,
Ralf Wildenhues <=