[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests defs: sanitize IFS
From: |
Stefano Lattarini |
Subject: |
Re: [PATCH] tests defs: sanitize IFS |
Date: |
Sun, 23 Jan 2011 13:24:01 +0100 |
User-agent: |
KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) |
On Sunday 23 January 2011, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Sun, Jan 23, 2011 at 12:56:45PM CET:
> > Done in the attached patch. OK for maint?
>
> OK.
>
> Comments explaining the unobvious bits of why something is done are much
> more helpful than comments explaining the obvious: what is done can be
> seen by reading the code. Please cf. the respective bits in
> gnulib/tests/init.sh: shorter but actually more informative:
>
> # As autoconf-generated configure scripts do, ensure that IFS
> # is defined initially, so that saving and restoring $IFS works.
> gl_init_sh_nl_='
> '
> IFS=" "" $gl_init_sh_nl_"
>
True indeed. I've amended the patch to use that comment, and pushed.
Thanks,
Stefano
- Re: [PATCH] {yacc-work} tests: more coverage on yacc/lex silent-rules, plus minor cleanups, (continued)
- Re: [PATCH] {yacc-work} tests: more coverage on yacc/lex silent-rules, plus minor cleanups, Ralf Wildenhues, 2011/01/22
- Re: [PATCH] {yacc-work} tests: more coverage on yacc/lex silent-rules, plus minor cleanups, Stefano Lattarini, 2011/01/22
- Re: [PATCH] {yacc-work} tests: more coverage on yacc/lex silent-rules, plus minor cleanups, Ralf Wildenhues, 2011/01/22
- [PATCH] coverage: test semantics of "dummy" per-object flags (was: Re: [PATCH] {yacc-work} tests: more coverage on yacc/lex silent-rules, plus minor cleanups), Stefano Lattarini, 2011/01/22
- Re: [PATCH] coverage: test semantics of "dummy" per-object flags, Ralf Wildenhues, 2011/01/22
- Re: [PATCH] coverage: test semantics of "dummy" per-object flags, Stefano Lattarini, 2011/01/23
- Re: [PATCH] coverage: test semantics of "dummy" per-object flags, Ralf Wildenhues, 2011/01/23
- Re: [PATCH] coverage: test semantics of "dummy" per-object flags, Stefano Lattarini, 2011/01/23
- [PATCH] tests defs: sanitize IFS (was: Re: [PATCH] coverage: test semantics of "dummy" per-object flags), Stefano Lattarini, 2011/01/23
- Re: [PATCH] tests defs: sanitize IFS, Ralf Wildenhues, 2011/01/23
- Re: [PATCH] tests defs: sanitize IFS,
Stefano Lattarini <=
- Re: [PATCH] {yacc-work} tests: more coverage on yacc/lex silent-rules, plus minor cleanups, Stefano Lattarini, 2011/01/22
- Re: [PATCH] {yacc-work} tests: more coverage on yacc/lex silent-rules, plus minor cleanups, Ralf Wildenhues, 2011/01/22