Re: [PATCH] test defs: add subroutine for input unindenting

[Ralf Wildenhues]

* Stefano Lattarini wrote on Mon, Feb 21, 2011 at 03:11:27PM CET:
> On Monday 21 February 2011, Ralf Wildenhues wrote:
> > It will be unintelligible without the comments, however.

> > gnulib-tool has a sed comment removal, search for
> > $sed_comments.  What I wouldn't like is invoking an extra sed in each
> > test startup just to remove comments from a helper function, that will
> > noticeably slow down things
> >
> Or the comments could be stripped lazily upon the first invocation of
> 'unindent'; e.g.:

Good idea.

> > (it could be removed at config.status time?);
> >
> But that would make more difficult to test with the same configuration
> and different sed implementations.

What I meant was to only remove the comments at config.status time.
That will still allow for testing different seds.

> > And I'll defer to Stefano's preference for or against complex code in
> > the testsuite.
> >
> I'm ok with the last implementation proposed by Peter, as long as there
> are sanity checks for it in the testsuite.  I can write those BTW, as
> I'm already preparing some other tests performing sanity checks on stuff
> in `tests/defs'.

Feel free to hash this out between you two.

Thanks,
Ralf