Re: bug#7648: [PATCH] {yacc-work} yacc: extension of headers modelled after extension of sources

[Ralf Wildenhues]

* Stefano Lattarini wrote on Sun, Apr 10, 2011 at 10:26:40AM CEST:
>  <http://lists.gnu.org/archive/html/automake-patches/2011-01/msg00306.html>
> 
> > Related to automake bug#7648 and PR automake/491.
> > 
> > * lib/am/yacc.am (am__yacc_c2h): New internal variable.
> > (?GENERIC?%EXT%%DERIVED-EXT%, ?!GENERIC?%OBJ%): Get the name of
> > the header dynamically at make runtime, so that its extension is
> > modelled after the extension of the source.
> > * automake.in (lang_yacc_target_hook): Adjust the calculation of
> > `$header' accordingly.
> > * tests/yacc-cxx.test: New test.
> > * tests/yacc-d-cxx.test: Likewise.
> > * tests/yacc-weirdnames.test: Likewise.
> > * tests/yacc-basic.test: Update comments.
> > * tests/yacc-d-basic.test: Likewise.
> > * tests/yaccpp.test: Updated and extended.
> > * tests/Makefile.am (TESTS): Update.
> > 
> This patch has been applied in the meantime, but it lacked NEWS and
> documentation updates.  I will post them soonish in two different
> patches.

While at it, you might want to fix

  > +// Valid as C++, but deliberatly invalid as C.

  deliberately

  I think you meant to write:
    Valid C++, but deliberately invalid C.

  > +#include <cstdio>
  > +#include <cstdlib>
  > +int yylex (void) { return (getchar ()); }

  Extra parentheses, not needed for return.

which is how far I got with reviewing before you pushed the patch.

Cheers,
Ralf