Re: merging msvc in branch-1.11

[Stefano Lattarini]

On Thursday 10 November 2011, Peter Rosin wrote:
> Stefano Lattarini skrev 2011-11-10 11:27:
>
> > [SNIP]
>
> > Attached is the patch I've pushed to remedy this situation.
> 
> Hmmm, I'd argue that when -Wextra-portability has been *explicitly*
> specified it is wrong for it to disappear into thin air when you specify
> --foreign (or one of the others).
>
And you'd be right :-)  The behaviour we're observing here is due to a bug
that has been fixed months ago in master, and will apear in automake 1.12.

See also merge `v1.11-1108-g38e1b39', in particular this excerpt from the
log message:

  * tests/extra-portability2.test: Fix this test not to rely
    on the older, faulty semantics of "strictness specification
    always reset warning level", which has been fixed in commit
    v1.11-623-g1609491 (see also automake bug#7669 a.k.a. PR/547).
    Since we are at it, throw inf few other minor unrelated
    improvements.

> Do you happen to know if it is still
> possibly to (re-)enable it by specifying -Wextra-portability after
> --foreign?
>
Yes, it should be; but this will become moot in automake 1.12 (about
time!).

> >> Another snag in the testsuite is that branch-1.11:tests/ltinit.test needs
> >> the below hunk (or similar) from testsuite-work in order to not fail on
> >> MinGW.
> >>
> >> @@ -57,7 +57,7 @@ $AUTOMAKE -a
> >>  cwd=`pwd`
> >>  ./configure --prefix="$cwd/inst" >stdout || { cat stdout; Exit 1; }
> >>  cat stdout
> >> -grep '^checking.*dlopen' stdout
> >> +grep '^checking.*dlfcn\.h.* no$' stdout || grep '^checking.*dlopen' stdout
> >>  
> >>  $MAKE
> >>  $MAKE install
> >>
> > Will you do that or should I?
> 
> Please go ahead, this...
> 
> > Oh, and BTW, I see that `ltinit.test' is present in `maint' too, so the
> > right fix is to apply the fix to `maint', and then merge `maint' into
> > `branch-1.11' (and `master' as well, in fact).
> 
> ...make me stay away from it. Thanks!
>
Why?  Honest question.

Anyway, I've applied the fix.  See the attached patch.

Thanks,
  Stefano

From 18f250e8c8d3c1b3b667937447515fd05095754e Mon Sep 17 00:00:00 2001
Message-Id: <address@hidden>
From: Stefano Lattarini <address@hidden>
Date: Thu, 10 Nov 2011 12:43:54 +0100
Subject: [PATCH] tests: avoid a spurious failure of 'ltinit.test' MinGW

* tests/ltinit.test: Be laxer in grepping configure output, to
avoid spurious failures on systems which lack POSIX dynamic
linking (e.g., MinGW), or when cross-compiling for such systems.

See also commit `v1.11-855-ge9e5d4a'.

Report and suggestion from Peter Rosin.
---
 ChangeLog         |    9 +++++++++
 tests/ltinit.test |    2 +-
 2 files changed, 10 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 8769d83..944183e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2011-11-10  Stefano Lattarini  <address@hidden>
+
+       tests: avoid a spurious failure of 'ltinit.test' MinGW
+       * tests/ltinit.test: Be laxer in grepping configure output, to
+       avoid spurious failures on systems which lack POSIX dynamic
+       linking (e.g., MinGW), or when cross-compiling for such systems.
+       See also commit `v1.11-855-ge9e5d4a'.
+       Report and suggestion from Peter Rosin.
+
 2011-11-08  Stefano Lattarini  <address@hidden>
 
        tests: testsuite is now safe to run with dmake in parallel mode
diff --git a/tests/ltinit.test b/tests/ltinit.test
index b4eaad6..85705e0 100755
--- a/tests/ltinit.test
+++ b/tests/ltinit.test
@@ -55,7 +55,7 @@ $AUTOMAKE -a
 cwd=`pwd`
 ./configure --prefix="$cwd/inst" >stdout || { cat stdout; Exit 1; }
 cat stdout
-grep '^checking.*dlopen' stdout
+grep '^checking.*dlfcn\.h.* no$' stdout || grep '^checking.*dlopen' stdout
 
 $MAKE
 $MAKE install
-- 
1.7.2.3