Re: [PATCH] release: don't run "make distcheck" automatically

[Stefano Lattarini]

On Saturday 10 December 2011, Jim Meyering wrote:
> Stefano Lattarini wrote:
> > * Makefile.am (git-dist): The developer might have already tested
> 
> "might"  Hah.
>
"The developers shall test extensively before finally creating
the release tarball" would sound better? :-)

> > extensively before finally creating the release tarball; so don't
> > run "make distcheck" here on his behalf; instead ...
> > * HACKING (Release procedure): ... state here that "make check"
> > and "make distcheck" should be run before calling "make git-dist".
> 
> Good idea.
> 
> > ---
> >  ChangeLog   |    9 +++++++++
> >  HACKING     |    3 ++-
> >  Makefile.am |    6 ++++--
> >  Makefile.in |    2 +-
> >  4 files changed, 16 insertions(+), 4 deletions(-)
> >
> > diff --git a/ChangeLog b/ChangeLog
> > index 618ab02..3873ace 100644
> > --- a/ChangeLog
> > +++ b/ChangeLog
> > @@ -1,3 +1,12 @@
> > +2011-12-10  Stefano Lattarini  <address@hidden>
> > +
> > +   release: don't run "make distcheck" automatically
> > +   * Makefile.am (git-dist): The developer might have already tested
> > +   extensively before finally creating the release tarball; so don't
> > +   run "make distcheck" here on his behalf; instead ...
> > +   * HACKING (Release procedure): ... state here that "make check"
> > +   and "make distcheck" should be run before calling "make git-dist".
> > +
> >  2011-12-09  Jim Meyering  <address@hidden>
> >         Stefano Lattarini  <address@hidden>
> >
> > diff --git a/HACKING b/HACKING
> > index b6f214f..f9b9c51 100644
> > --- a/HACKING
> > +++ b/HACKING
> > @@ -203,7 +203,8 @@
> >
> >  * Update ChangeLog.
> >
> > -* Run ./bootstrap, ./configure, make.
> > +* Run "./bootstrap", "./configure", "make", "make check" and
> > +  "make distcheck".
> 
> I would make it actually runnable, i.e.,
> 
> Run these commands:
> 
>   ./bootstrap && ./configure && make && make check && make distcheck
> 
Seems sensible; consider this fixed.

Thanks,
  Stefano