[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#59993] [PATCH 2/2] tests: Fix implicit function declaration errors
From: |
Zack Weinberg |
Subject: |
[bug#59993] [PATCH 2/2] tests: Fix implicit function declaration errors |
Date: |
Wed, 28 Dec 2022 22:20:50 -0500 |
User-agent: |
Wanderlust/2.15.9 (Almost Unreal) |
On Thu, 15 Dec 2022 11:48:44 -0500, Frederic Berat wrote:
> On Mon, Dec 12, 2022 at 9:19 PM Zack Weinberg <zack@owlfolio.org> wrote:
> > > return yylex ();
> > Please change `int main ()` to `int main (void)` as long as you're in here.
> I'm hesitant on this. That isn't the purpose of the patch, and if I
> start to do that, there are about 48 files that would need to be
> touched (which omit void for empty argument list).
Yeah, I suppose that ought to be its own separate patch, in that
case.
> Kind of a noisy change with no real benefit.
It’d be a step in the direction of making the testsuite run cleanly
with -Wstrict-prototypes and/or -Wold-style-definition, which might
plausibly help with the related effort to support compilers that
reject old-style definitions. But I agree that it’s not a high
priority and shouldn’t block this patch.
zw
- [bug#59992] [PATCH 1/2] tests: Fix 'type defaults' error in link_cond due to main not being properly declared, (continued)
[bug#59992] [PATCH v2 1/3] tests: Fix 'type defaults' error in link_cond due to main not being properly declared, Frederic Berat, 2022/12/16
[bug#59993] [PATCH 2/2] tests: Fix implicit function declaration errors, Frederic Berat, 2022/12/12
[bug#59993] [PATCH 2/2] tests: Fix implicit function declaration errors, Frederic Berat, 2022/12/15
[bug#59993] [PATCH 2/2] tests: Fix implicit function declaration errors,
Zack Weinberg <=
[bug#59993] [PATCH v2 2/3] tests: Fix implicit function declaration errors, Frederic Berat, 2022/12/16
[bug#59993] [PATCH v2 3/3] tests: Fix implicit function declaration in ax/depcomp.sh, Frederic Berat, 2022/12/16
[bug#59991] [PATCH 0/2] Port tests to modern C, Karl Berry, 2022/12/12
[bug#59991] [PATCH v2 0/3] Port tests to modern C, Frederic Berat, 2022/12/16