[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [avr-libc-dev] [PATCH] printf: %s arguments with precision
From: |
Theodore A. Roth |
Subject: |
Re: [avr-libc-dev] [PATCH] printf: %s arguments with precision |
Date: |
Thu, 12 Feb 2004 12:52:00 -0800 (PST) |
On Thu, 12 Feb 2004, Joerg Wunsch wrote:
> As Christopher Hoover wrote:
>
> > > I would prefer a version that doesn't call strlen()/strnlen()
> > > though, in particular in the PRINTF_MIN case.
> >
> > I can do that, but can you explain why that is preferred?
>
> Code size, but I withdraw that remark, after looking at the actual
> implementations of strlen/strnlen vs. the code compiled from that
> `inlined' version of strlen. ;-)
>
> I'm going to accept your patch verbatim, after a bit of testing.
>
One other thing to think about is stack usage. Using functions may
increase stack usage, but in this case, that is probably not a concern
since you are calling other lib function in vfprintf already.
Ted Roth
- [avr-libc-dev] [PATCH] printf: %s arguments with precision, Christopher Hoover, 2004/02/01
- Re: [avr-libc-dev] [PATCH] printf: %s arguments with precision, Joerg Wunsch, 2004/02/02
- RE: [avr-libc-dev] [PATCH] printf: %s arguments with precision, Christopher Hoover, 2004/02/02
- Re: [avr-libc-dev] [PATCH] printf: %s arguments with precision, Joerg Wunsch, 2004/02/12
- Re: [avr-libc-dev] [PATCH] printf: %s arguments with precision, Joerg Wunsch, 2004/02/12
- Re: [avr-libc-dev] [PATCH] printf: %s arguments with precision, Theodore A. Roth, 2004/02/12
- Re: [avr-libc-dev] [PATCH] printf: %s arguments with precision, Joerg Wunsch, 2004/02/15
Re: [avr-libc-dev] [PATCH] printf: %s arguments with precision, Joerg Wunsch, 2004/02/02