Re: bison reader.c

[Paul Eggert]

twlevo <address@hidden> writes:

> reader.c line 520, looks like it should close the gram_in filestream at the 
> if there. co.

Thanks.  That's a very minor leak, since the program will exit soon
anyway, but it shouldn't hurt to close it.  I installed this:

2006-01-22  Paul Eggert  <address@hidden>

        * src/reader.c (check_and_convert_grammar): New function.
        (reader): Close the input file even if something went wrong during
        parsing.  Minor file descriptor leak reported by twlevo.

--- src/reader.c        21 Jan 2006 04:35:09 -0000      1.250
+++ src/reader.c        23 Jan 2006 04:37:09 -0000      1.251
@@ -36,6 +36,8 @@
 #include "symlist.h"
 #include "symtab.h"
 
+static void check_and_convert_grammar (void);
+
 static symbol_list *grammar = NULL;
 static bool start_flag = false;
 merger_list *merge_functions;
@@ -515,12 +517,22 @@ reader (void)
   scanner_initialize ();
   gram_parse ();
 
-  /* If something went wrong during the parsing, don't try to
-     continue.  */
-  if (complaint_issued)
-    return;
+  if (! complaint_issued)
+    check_and_convert_grammar ();
+
+  xfclose (gram_in);
+}
+
 
-  /* Grammar has been read.  Do some checking */
+/*-------------------------------------------------------------.
+| Check the grammar that has just been read, and convert it to |
+| internal form.                                              |
+`-------------------------------------------------------------*/
+
+static void
+check_and_convert_grammar (void)
+{
+  /* Grammar has been read.  Do some checking.  */
   if (nrules == 0)
     fatal (_("no rules in the input grammar"));
 
@@ -537,7 +549,7 @@ reader (void)
       endtoken->user_token_number = 0;
     }
 
-  /* Insert the initial rule, which line is that of the first rule
+  /* Insert the initial rule, whose line is that of the first rule
      (not that of the start symbol):
 
      accept: %start EOF.  */
@@ -555,8 +567,6 @@ reader (void)
 
   assert (nsyms <= SYMBOL_NUMBER_MAXIMUM && nsyms == ntokens + nvars);
 
-  xfclose (gram_in);
-
   /* Assign the symbols their symbol numbers.  Write #defines for the
      token symbols into FDEFINES if requested.  */
   symbols_pack ();