Re: [Bug-apl] Assertion failure in scalar function with empty right argument

[Juergen Sauermann]

Hi Kacper,

thanks, fixed in SVN 274.

Normally one should exit() after an assertion failed. Sometimes, however,
staying in the program gives an opportunity to collect more information.
Most of the time, though, a failed assertion causes a subsequent 
segfault which
makes even simple faults look horrible.

Maybe I should make this behavior configurable.
And I will check where the segfault comes from.

/// Jürgen


On 05/19/2014 04:59 PM, Kacper Gutowski wrote:
> Thanks for previous two.  Is it expected, by the way, that assert
> ends in a segfault?  Isn't this also a bug?
>
> Anyway, any scalar function given empty right argument and non-conforming
> non-empty left argument misses check for shape equality:
>
>
>        ⍬ = 1 2
> LENGTH ERROR
>        ⍬=1 2
>        ^^
>        →
>        1 2 = ⍬
>
> ==============================================================================
> Assertion failed: A->same_shape(*B)
> in Function:      eval_fill_AB
> in file:          SkalarFunction.cc:318
>
> Call stack:
>
> ----------------------------------------
> -- Stack trace at SkalarFunction.cc:318
> ----------------------------------------
> 0x7fd11cda6b45 __libc_start_main
> 0x435995  main
> 0x529e6d   Workspace::immediate_execution(bool)
> 0x4651cd    Command::process_line()
> 0x463f99     Command::process_line(UCS_string&)
> 0x46e678      Executable::execute_body() const
> 0x4e4390       StateIndicator::run()
> 0x49133a        Prefix::reduce_statements()
> 0x48e293         Prefix::reduce_A_F_B_()
> 0x4e516a          StateIndicator::eval_AB(Token&, Token&, Token&)
> 0x4df198           Bif_F2_EQUAL::eval_AB(Value_P, Value_P)
> 0x4dabcd            SkalarFunction::eval_skalar_AB(Value_P, Value_P, ErrorCode 
> (Cell::*)(Cell*, Cell const*) const)
> 0x4d8db4             SkalarFunction::eval_fill_AB(Value_P, Value_P)
> 0x443abf              do_Assert(char const*, char const*, char const*, int)
> ========================================
>
> SI stack:
>
> Depth:    0
> Exec:     0x1399920
> Safe ex:  no
> Pmode:    ◊  1 2 = ⍬
> PC:       3 ENDL
> Stat:     1 2 = ⍬
> err_code: 0x0
> thrown:   at StateIndicator.cc:41
> e_msg_1:  'No Error'
> e_msg_2:  ''
> e_msg_3:  ''
>
>
> ==============================================================================
>
>
> ====================================================
> SEGMENTATION FAULT
>
> ----------------------------------------
> -- Stack trace at main.cc:122
> ----------------------------------------
> 0x7fd11cda6b45 __libc_start_main
> 0x435995  main
> 0x529e6d   Workspace::immediate_execution(bool)
> 0x4651cd    Command::process_line()
> 0x463f99     Command::process_line(UCS_string&)
> 0x46e678      Executable::execute_body() const
> 0x4e4390       StateIndicator::run()
> 0x49133a        Prefix::reduce_statements()
> 0x48e293         Prefix::reduce_A_F_B_()
> 0x4e516a          StateIndicator::eval_AB(Token&, Token&, Token&)
> 0x4df198           Bif_F2_EQUAL::eval_AB(Value_P, Value_P)
> 0x4dabcd            SkalarFunction::eval_skalar_AB(Value_P, Value_P, ErrorCode 
> (Cell::*)(Cell*, Cell const*) const)
> 0x4d8db4             SkalarFunction::eval_fill_AB(Value_P, Value_P)
> 0x443a67              do_Assert(char const*, char const*, char const*, int)
> 0x501acc               TestFiles::assert_error()
> 0x7fd11ecfd890
> 0x47e22a
> ========================================
> ====================================================
>
>
> -k