Re: SVN 1704 completely broke libedif

[Chris Moller]

    Yeah, I saw your comment in one of the .hh files. 
      What I did was wrap all the edif ASCII strings in UTF8_string()
      calls.  That works, but if it's circumventing what you're trying
      to do, let me know and I'll think of something else.  
      
      Even after a lot of years, I'm still not sure of the differences
      between UTF, UCS, Unicode, etc, etc.
      
      --cm

On 6/6/23 15:56, Dr. Jürgen Sauermann wrote:

Hi,

sorry for that. The reason for making it private is to entirely prevent its usage.
The former implementation of of it only worked for ASCII strings. There was
a note about that in the header file, but I have seen quite a few incorrect
usages of it (read: with UTF8-encoded strings) which then caused other, difficult
to find, errors later on.

Best Regards,
Jürgen

On 6/6/23 17:31, Chris Moller wrote:

Hi, Xtian,

Just pushed a fix for edif if you want to give it a try.  Works for me on SVN 1706 and yesterday's SVN 1708.

--cm

On 6/5/23 03:33, Christian Robert wrote:

SVN 1704 completely broke libedif

Juergen made UCS_string (const char *)  a private member of the class
so a lot of compile errors in edif.cc ...

Not sure if this can be fixed. I reverted to SVN 1702 meanwhile. The is no way I'll revert to the "DEL Editor" !


Xtian.

OpenPGP_0xDA6C01938888083E.asc
Description: OpenPGP public key

OpenPGP_signature
Description: OpenPGP digital signature