[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#54063: [PATCH] automake: fall back gracefully when texinfo inputs do
From: |
Mike Frysinger |
Subject: |
bug#54063: [PATCH] automake: fall back gracefully when texinfo inputs don't exist |
Date: |
Thu, 24 Feb 2022 22:32:24 -0500 |
Fixes automake bug https://bugs.gnu.org/54063.
The function scanning for @setfilename will fall back to a default
value if the input doesn't have one defined. But we need to handle
the case where the file doesn't even exist before falling back.
* bin/automake.in: Scan /dev/null for @setfilename if input doesn't exist.
* t/list-of-tests.mk: Add txinfo-no-setfilename-no-inputs.sh.
* t/txinfo-no-setfilename-no-inputs.sh: New test.
---
bin/automake.in | 4 +++-
t/list-of-tests.mk | 1 +
t/txinfo-no-setfilename-no-inputs.sh | 31 ++++++++++++++++++++++++++++
3 files changed, 35 insertions(+), 1 deletion(-)
create mode 100644 t/txinfo-no-setfilename-no-inputs.sh
diff --git a/bin/automake.in b/bin/automake.in
index 5eba649d240c..13ad4329caeb 100644
--- a/bin/automake.in
+++ b/bin/automake.in
@@ -3062,7 +3062,9 @@ sub scan_texinfo_file
{
my ($filename) = @_;
- my $texi = new Automake::XFile "< $filename";
+ # If the source file doesn't exist, we'll fall back below.
+ my $source = -e $filename ? $filename : "/dev/null";
+ my $texi = new Automake::XFile "< $source";
verb "reading $filename";
my ($outfile, $vfile);
diff --git a/t/list-of-tests.mk b/t/list-of-tests.mk
index d959b68db47b..ec08891555e7 100644
--- a/t/list-of-tests.mk
+++ b/t/list-of-tests.mk
@@ -1229,6 +1229,7 @@ t/txinfo-no-extra-dist.sh \
t/txinfo-no-installinfo.sh \
t/txinfo-no-repeated-targets.sh \
t/txinfo-no-setfilename.sh \
+t/txinfo-no-setfilename-no-inputs.sh \
t/txinfo-other-suffixes.sh \
t/txinfo-override-infodeps.sh \
t/txinfo-override-texinfo-tex.sh \
diff --git a/t/txinfo-no-setfilename-no-inputs.sh
b/t/txinfo-no-setfilename-no-inputs.sh
new file mode 100644
index 000000000000..4cedb2f88d81
--- /dev/null
+++ b/t/txinfo-no-setfilename-no-inputs.sh
@@ -0,0 +1,31 @@
+#! /bin/sh
+# Copyright (C) 2022 Free Software Foundation, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2, or (at your option)
+# any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <https://www.gnu.org/licenses/>.
+
+# Check Texinfo files work without a @setfilename line and no input files.
+# https://bugs.gnu.org/54063
+
+. test-init.sh
+
+cat > Makefile.am << 'END'
+info_TEXINFOS = file.texi
+END
+
+$ACLOCAL
+$AUTOMAKE --add-missing
+
+grep 'file.info:' Makefile.in
+
+:
--
2.34.1
- bug#54063: automake cannot run without generated Texinfo manual, (continued)
- bug#54063: automake cannot run without generated Texinfo manual, Mike Frysinger, 2022/02/24
- bug#54063: automake cannot run without generated Texinfo manual, Patrice Dumas, 2022/02/24
- bug#54063: automake cannot run without generated Texinfo manual, Mike Frysinger, 2022/02/24
- bug#54063: automake cannot run without generated Texinfo manual, Patrice Dumas, 2022/02/25
- bug#54063: automake cannot run without generated Texinfo manual, Karl Berry, 2022/02/25
- bug#54063: automake cannot run without generated Texinfo manual, pertusus, 2022/02/25
- bug#54063: automake cannot run without generated Texinfo manual, Karl Berry, 2022/02/25
- bug#54063: automake cannot run without generated Texinfo manual, pertusus, 2022/02/25
- bug#54063: automake cannot run without generated Texinfo manual, Mike Frysinger, 2022/02/26
- bug#54063: automake cannot run without generated Texinfo manual, pertusus, 2022/02/26
bug#54063: [PATCH] automake: fall back gracefully when texinfo inputs don't exist,
Mike Frysinger <=