Re: enhancement merge request

[Lawrence Velázquez]

Hi,

> On Apr 18, 2021, at 12:03 AM, Ananth Chellappa <ananth.ch@gmail.com> wrote:
> 
> Hello Brian and Chet,
>         Please consider merging the enhancement made by Naseeba described
> here :
> 
> https://github.com/ananthchellappa/bash-5.1/blob/main/README.md

In your future emails, you may want to consider

- writing a subject that provides a useful summary of the purpose
  or contents of the email,
- writing a body that contains your message or a useful summary of
  it, and
- not requiring readers to visit an external website to learn
  literally the first thing about what you wish to discuss.

Here's the relevant description from that README:

        This version of bash contains the below described update
        done by **Naseeba Kilayil** through Upwork :

        Currently, when you do set +o history, then commands are
        no longer logged to ~/.bash_history. The problem is that
        while you get the privacy, you also lose command recall
        with !number and arrow-keys. So we want to **enhance**
        `set +o history` to suspend logging to ~/.bash_history,
        but (while in private mode - i.e., till you do `set -o
        history`) you do get command recall with !number and
        arrow keys. These private mode commands will, of course,
        be forgotten once user exits private mode.

The history feature encompasses a lot more than just saving to the
history file.  The idea of `set +o history` leaving history expansion
and command recall enabled makes no sense to me; those *are* history
features.

Is the desired outcome just to retain all history features except
persistence to ~/.bash_history (or any other file)?  If so, this
can be accomplished by unsetting HISTFILE.

P.S. I've attached the patches from the aforelinked Git repository,
for the curious.

-- 
vq

0001-Always-keep-history.txt
Description: Text document

0002-tag-history-entry-as-private.txt
Description: Text document

0003-scrub-private-history-when-exiting-private-mode.txt
Description: Text document

0004-prevent-private-history-from-being-written-at-exit.txt
Description: Text document

0005-add-Naseeba-s-name.txt
Description: Text document

0006-Credit-to-Naseeba.txt
Description: Text document

0007-Rename-README-to-README.md.txt
Description: Text document

0008-minor-formatting-issue.txt
Description: Text document