From 4ca64cfc3de1d9cf75490b85891e88fbf0405538 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Wed, 13 Mar 2024 17:00:17 -0700 Subject: [PATCH 1/5] printf now diagnoses underlying printf failure * builtins/printf.def (printf_builtin): Report an error if printf returns -1, even when -v is not used, so that a shell command like "printf '%10000000000000000000000000000s' ''" does not fail silently. --- builtins/printf.def | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/builtins/printf.def b/builtins/printf.def index 49757f5c..b1140dc4 100644 --- a/builtins/printf.def +++ b/builtins/printf.def @@ -178,8 +178,7 @@ extern int errno; if (nw < 0 || (vflag == 0 && ferror (stdout))) \ { \ QUIT; \ - if (vflag) \ - builtin_error ("%s", strerror (errno)); \ + builtin_error ("%s", strerror (errno)); \ PRETURN (EXECUTION_FAILURE); \ } \ tw += nw; \ -- 2.44.0