bug-bash
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/9] bashgetopt: define long option shortener function


From: Koichi Murase
Subject: Re: [PATCH 4/9] bashgetopt: define long option shortener function
Date: Tue, 7 May 2024 19:35:23 +0900

2024年5月5日(日) 18:57 Matheus Afonso Martins Moreira
<matheus.a.m.moreira@gmail.com>:
> Define the shorten_long_options helper function that converts

Let's talk about whether we should support the long form of the option
in this patch set.

2024年5月7日(火) 2:11 Matheus Afonso Martins Moreira <matheus@matheusmoreira.com>:
> > incomplete addition of the long option of builtins
>
> What do you mean? What is missing?

It's simply inconsistent in the present form. Why should only the
source builtin have the long form of the option? No other builtins
have the long form of options, which is inconsistent. Suppose you
would submit an independent patch to introduce the long option of
builtins in Bash. Would you do that only for the source builtin? If
you consider the current form would be complete, you should provide
the reason that the other builtins should not have the long form of
the options, while only the source builtin should have a long option.

If one tries to give the long options to all the existing builtins,
that should be discussed separately. I don't think those changes are
allowed to slip in as a bonus of another change on the source builtin.
I'm not sure about what Chet thinks, but I don't think those are
really necessary, though it's a better design in general.

I also have thoughts on the way how this was implemented, but I
wouldn't discuss it for now.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]