STRTOLD_BROKEN test fails with gcc14

[af]

Configuration Information [Automatically generated, do not change]:
Machine: x86_64
OS: solaris2.11
Compiler: /opt/gcc-14/bin/gcc
Compilation CFLAGS: -O2 -fno-omit-frame-pointer 
-fno-aggressive-loop-optimizations -fstack-protector-strong -gdwarf-2 
-gstrict-dwarf -I/usr/include/ncurses -gdwarf-2 -gstrict-dwarf -m64
uname output: SunOS build 5.11 omnios-r151050-6f87d0b5d63 i86pc i386 i86pc
Machine Type: x86_64-pc-solaris2.11

Bash Version: 5.2
Patch Level: 26
Release Status: release

Description:

When configuring bash with gcc-14, we end up with STRTOLD_BROKEN being set
since the test program fails with:

conftest.c: In function 'main':
conftest.c:295:49: warning: passing argument 2 of 'strtold' from incompatible
pointer type [-Wincompatible-pointer-types]
  295 | long double r; char *foo, bar; r = strtold(foo, &bar);
      |                                                 ^~~~
      |                                                 |
      |                                                 char *
In file included from /usr/include/stdlib.h:42,
                 from conftest.c:291:
/usr/include/iso/stdlib_c99.h:77:56: note: expected 'char ** restrict' but
argument is of type 'char *'
   77 | extern long double strtold(const char *_RESTRICT_KYWD, char
      **_RESTRICT_KYWD);

Repeat-By:

        Run configure on a system with gcc-14

Fix:

        The definition of `bar` in the test is missing a `*`:

        [AC_COMPILE_IFELSE(
                [AC_LANG_PROGRAM(
                [[#include <stdlib.h>]],
-               [[long double r; char *foo, bar; r = strtold(foo, &bar);]]
+               [[long double r; char *foo, *bar; r = strtold(foo, &bar);]]
        )],

-- 
Citrus IT Limited | +44 (0)333 0124 007 | enquiries@citrus-it.co.uk
Rock House Farm | Green Moor | Wortley | Sheffield | S35 7DQ
Registered in England and Wales | Company number 4899123