[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] histfile: fix mmap page alignment
From: |
Chet Ramey |
Subject: |
Re: [PATCH] histfile: fix mmap page alignment |
Date: |
Fri, 18 Oct 2024 12:15:38 -0400 |
User-agent: |
Mozilla Thunderbird |
On 10/18/24 11:51 AM, Chet Ramey wrote:
On 10/17/24 8:27 PM, Grisha Levit wrote:
The mmap in history_do_write would usually fail when appending because
the offset must be a multiple of the page size.
Thanks for the report. Not everyone requires this, but since some systems
do, it's better to do this for portability.
Of course, the fact that nothing defines HISTORY_USE_MMAP limits the
impact somewhat.
--
``The lyf so short, the craft so long to lerne.'' - Chaucer
``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU chet@case.edu http://tiswww.cwru.edu/~chet/
OpenPGP_signature.asc
Description: OpenPGP digital signature